Add missing rules and improve tests #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rplopes
reviewed
Mar 2, 2017
test/fixtures/incorrect.js
Outdated
| @@ -123,17 +131,16 @@ try { | |||
| noop(); | |||
| } catch (e) {} | |||
|
|
|||
| // `no-labels`. | |||
| // `no-labels` and `no-unused-labels`. | |||
There was a problem hiding this comment.
We're not using no-unused-labels in our list of rules. Should we ignore this, since it's a rule that gets redundant by no-labels anyway?
There was a problem hiding this comment.
Good point. I used the label in the fixtures so that this particular rule no longer triggers.
test/fixtures/incorrect.js
Outdated
| @@ -193,10 +196,10 @@ noop(oneVar1); | |||
| noop(oneVar2); | |||
|
|
|||
| // `one-var-declaration-per-line`. | |||
| const oneVar1 = 'foo'; const oneVar2 = 'bar'; | |||
| const oneVar3 = 'foo'; const oneVar4 = 'bar'; | |||
There was a problem hiding this comment.
Having these variables start counting at 3 is weird. Follow another naming pattern maybe?
nunofgs
force-pushed
the
bugfix/fix-missing-rules-in-tests
branch
2 times, most recently
from
804d70a to
737599c
Compare
nunofgs
force-pushed
the
bugfix/fix-missing-rules-in-tests
branch
from
737599c to
963e693
Compare
rplopes
approved these changes
Mar 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: