Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leaking transaction, favor transaction from context over creating new one #29

Merged
merged 2 commits into from
May 26, 2021
Merged

Fix leaking transaction, favor transaction from context over creating new one #29

merged 2 commits into from
May 26, 2021

Commits on May 26, 2021

  1. Favor context.trx over new trx created from Model 

    When doing operations within a transaction a new one was started rather
than using the current one, causing a "leaking" connection. This became
more evident when trying to run tests with only 1 connection pool.
    @dawaa
    dawaa committed May 26, 2021
    Configuration menu
    Copy the full SHA
    10f6c9d View commit details
    Browse the repository at this point in the history

  2. Resolve no-unused-vars lint violation

    @dawaa
    dawaa committed May 26, 2021
    Configuration menu
    Copy the full SHA
    33e18c3 View commit details
    Browse the repository at this point in the history