Add Sandbox option #137
Merged
Add Sandbox option #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds sandbox option allowing to choose which API url will be used on the client requests. It is also possible to provide `base_url` option to override this behaviour.
This adds sandbox option to CreateTokenCommand allowing to create a token in Uphold Sandbox.
This adds sandbox option to all examples. This makes the developers aware of the sandbox option, although it's not mandatory.
This adds sandbox option as true to the functional tests using the Sandbox API instead of the production one.
nunorafaelrocha
force-pushed
the
feature/sandbox-client-option
branch
from
23256b8 to
5246366
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds sandbox option allowing to choose which API url will be used on the client requests. It is also possible to provide
base_urloption to override this behaviour.The sandbox option was added to CreateTokenCommand allowing to create a token in Uphold Sandbox.
This also adds sandbox option as true to the functional tests using the Sandbox API instead of the production one.
All examples were updated with the sandbox option which makes the developers aware of the sandbox option, although it's not mandatory.
Closes #84.