Update card.getAddresses method to retrieve from API #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunorafaelrocha
force-pushed
the
enhancement/card-get-addresses
branch
7 times, most recently
from
3205c7c to
f720cff
Compare
| @@ -177,8 +172,6 @@ public function createCryptoAddress($network) | |||
| { | |||
| $response = $this->client->post(sprintf('/me/cards/%s/addresses', $this->id), array('network' => $network)); | |||
There was a problem hiding this comment.
Any reason to assign the api response?
nunorafaelrocha
force-pushed
the
enhancement/card-get-addresses
branch
from
f720cff to
b5bd10d
Compare
nunorafaelrocha
force-pushed
the
enhancement/card-get-addresses
branch
from
b5bd10d to
8550854
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
card.getAddressesmethod by removing the$addressesproperty from the model which no longer is provided on the/me/cards/:cardId.Now, when the user calls the
card.getAddressesmethod a request is made to the Uphold's API which retrieves the card's list of addresses.