refactor: specify venv in pyright config (#430)

tell pyright where to find the venv so we don't need to have it activated for type checking to find imports plus it looks a little cleaner
seek-oss · May 14, 2023 · 242d7c3 · 242d7c3
1 parent a1b3105
commit 242d7c3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/Makefile b/Makefile
@@ -46,8 +46,7 @@ node_modules: package.json
 
 ## pyright
 pyright: node_modules $(venv)
-# activate venv so pyright can find dependencies
-	PATH="$(venv)/bin:$$PATH" node_modules/.bin/pyright
+	node_modules/.bin/pyright
 
 ## run tests
 test: $(venv)

diff --git a/pyproject.toml b/pyproject.toml
@@ -51,6 +51,8 @@ requires = ["setuptools", "setuptools_scm[toml]", "wheel"]
 line-length = 120
 
 [tool.pyright]
+venvPath = "."
+venv = ".venv"
 include = ["src", "tests"]
 strictListInference = true
 strictDictionaryInference = true