Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RadioItem: Add disabled support #1108

Merged
merged 2 commits into from
May 15, 2022
Merged

RadioItem: Add disabled support #1108

merged 2 commits into from
May 15, 2022

Conversation

michaeltaranto
Copy link
Contributor

@michaeltaranto michaeltaranto commented May 13, 2022

Provide support for disabling individual RadioItems within a RadioGroup.

EXAMPLE USAGE:

<RadioGroup>
  <RadioItem label="One" value="1" />
  <RadioItem label="Two" value="2" />
  <RadioItem label="Three" value="3" disabled={true} />
</RadioGroup>

Wanted to add a test around the keyboard flow here, but testing-library doesnt support the native arrow key behaviour not being implemented as yet. Will keep an eye on the issue as this would be valuable to add in the future.

@michaeltaranto michaeltaranto requested a review from a team as a code owner May 13, 2022 05:52
@changeset-bot
Copy link

changeset-bot bot commented May 13, 2022

🦋 Changeset detected

Latest commit: 68435de

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
braid-design-system Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@michaeltaranto michaeltaranto merged commit 35cc901 into master May 15, 2022
@michaeltaranto michaeltaranto deleted the radioitem-disable branch May 15, 2022 22:42
@seek-oss-ci seek-oss-ci mentioned this pull request May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants