build: Rename to eslint-config-seek #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
|
|
||
| This package includes the shareable ESLint configuration used by [sku](https://github.com/seek-oss/sku). | ||
| This package includes the shareable ESLint configuration used by SEEK. |
There was a problem hiding this comment.
Our pattern with the other config repos has been linking SEEK to github.com/seek-oss
jahredhope
force-pushed
the
rename-to-seek
branch
from
af79d70 to
a8180f2
Compare
BREAKING CHANGE:
Replace all use of sku with seek.
Before:
.eslintconfig
{
extend: ['sku']
}
After:
.eslintconfig
{
extend: ['seek']
}
jahredhope
force-pushed
the
rename-to-seek
branch
from
a8180f2 to
864916d
Compare
markdalgleish
approved these changes
Jan 9, 2018
|
Looks good, I'm curious though why step 3 is necessary? Do we really need to publish v2.0.1 under the new name? Can't we just have v3 be the first |
michaeltaranto
approved these changes
Jan 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will rename
eslint-config-skutoeslint-config-seek, better representing it's use outside sku based projects.Rename process
In order to rename this module we'll be following the semantic-release renaming guide
rename-to-seekbranch locallyv2.0.1npm publishfrom local machine.0.0.0_developmentThis final step will create a new major version release of
v3.0.0Last version of
eslint-config-sku:v2.0.1First version of
eslint-config-seek:v2.0.1First modified version of eslint-config-seek:
v3.0.0Post migration
Once the new package is confirmed deployed deprecate
eslint-config-skuwith message 'eslint-config-sku has been renamed to eslint-config-seek'.https://docs.npmjs.com/cli/deprecate
Commit message for review
BREAKING CHANGE:
Replace all use of sku with seek.
Before
.eslintconfig
{ "extend": ["sku"] }After
.eslintconfig
{ "extend": ["seek"] }