-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save code editor size preference as percentage #363
Conversation
🦋 Changeset detectedLatest commit: 6f61b4f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Michael Taranto <michaeltaranto@users.noreply.github.com>
Co-authored-by: Michael Taranto <michaeltaranto@users.noreply.github.com>
3c4ced3
to
8e50103
Compare
Convert preference to percentage on load
cc2cb89
to
e301da5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Much nicer experience when resizing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So good. Love where this landed, very tidy 👏
See changeset.
Setting the defaults to 40% as these look pretty good even at smaller screen sizes, but open to suggestions if this should be different.