Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set minimumReleaseAge to 0 for @seek/ #127

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Set minimumReleaseAge to 0 for @seek/ #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9cfed30
What could go wrong :fire:
samchungy Oct 14, 2024
8f6d1b4
prettier
samchungy Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions default.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Gives us nicer DX

"extends": [
":dependencyDashboard",
":rebaseStalePrs",
Expand Down Expand Up @@ -235,6 +236,14 @@
"minimumReleaseAge": "0 days",
"updateNotScheduled": true
},
{
"matchManagers": ["npm"],
"matchDepNames": ["^@seek/*"],
"matchUpdateTypes": ["major", "minor", "patch"],
"schedule": "before 3:00 am every weekday",
"minimumReleaseAge": "0 days",
"updateNotScheduled": true
},
Comment on lines +239 to +246
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be the same as

rynovate/default.json

Lines 150 to 158 in 8f6d1b4

{
"matchDepNames": ["braid-design-system", "sku", "skuba"],
"matchPackagePatterns": ["^@?seek", "seek$", "^@vanilla-extract/"],
"prPriority": 98,
"schedule": "after 3:00 am and before 6:00 am every weekday",
"minimumReleaseAge": "0 days",
"updateNotScheduled": true
},

It's possible there's an issue with specifying both matchDepNames and matchPackagePatterns, and we should probably migrate all of the latter to the former across the configuration.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly, I'll give it a test in my renovate repo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooo I think we want packageName so matchPackageName

renovatebot/renovate#14885 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That comment confuses me 😂

{
"matchDepNames": ["react-relay"],
"matchPackagePatterns": ["^relay-"],
Expand Down
1 change: 1 addition & 0 deletions non-critical.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": [
":dependencyDashboard",
":prHourlyLimit2",
Expand Down
1 change: 1 addition & 0 deletions third-party-major.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": [
":dependencyDashboard",
":prHourlyLimit4",
Expand Down
Loading