Skip to content
This repository has been archived by the owner on Sep 14, 2021. It is now read-only.

fix(Footer): Fix NZ SEEK Business link #634

Merged
merged 3 commits into from
Jul 29, 2019
Merged

fix(Footer): Fix NZ SEEK Business link #634

merged 3 commits into from
Jul 29, 2019

Conversation

adenj
Copy link
Contributor

@adenj adenj commented Jul 26, 2019

No description provided.

@@ -115,7 +115,8 @@ export const seekSites = [
},
{
name: 'Business for sale',
href: 'https://www.seekbusiness.co.nz/?tracking=sk:main:nz:nav:bus',
href:
'https://www.seekbusiness.com.au/?site=nz&tracking=sk%3Amain%3Anz%3Anav%3Abus',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should line 112 (AU link) also be encoded?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly. I've tried to only change what I've been requested to 😅

Copy link
Contributor

@georgespyropoulos georgespyropoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reckon it would be worth updating the AU link as well. I suspect the requirement would apply to both links

@adenj adenj merged commit 229250f into master Jul 29, 2019
@adenj adenj deleted the fix-business-link branch July 29, 2019 03:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants