Skip to content
This repository has been archived by the owner on Sep 14, 2021. It is now read-only.

fix(Footer): Fix NZ SEEK Business link #634

Merged
merged 3 commits into from
Jul 29, 2019
Merged

fix(Footer): Fix NZ SEEK Business link #634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
527a89a
fix(Footer): Fix NZ SEEK Business link
adenj Jul 26, 2019
ef0035c
remove withTextProps.js from PR
adenj Jul 26, 2019
b7ea15b
wip
adenj Jul 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions react/Footer/__snapshots__/Footer.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ exports[`Footer: should render when authenticated 1`] = `
<a
class="FooterLink__link"
data-analytics="toolbar:business+for+sale"
href="https://www.seekbusiness.com.au/?tracking=sk:main:au:nav:bus"
href="https://www.seekbusiness.com.au/?tracking=sk%3Amain%3Aau%3Anav%3Abus"
>
Business for sale
</a>
Expand Down Expand Up @@ -1062,7 +1062,7 @@ exports[`Footer: should render when authentication is pending 1`] = `
<a
class="FooterLink__link"
data-analytics="toolbar:business+for+sale"
href="https://www.seekbusiness.com.au/?tracking=sk:main:au:nav:bus"
href="https://www.seekbusiness.com.au/?tracking=sk%3Amain%3Aau%3Anav%3Abus"
>
Business for sale
</a>
Expand Down Expand Up @@ -1896,7 +1896,7 @@ exports[`Footer: should render when unauthenticated 1`] = `
<a
class="FooterLink__link"
data-analytics="toolbar:business+for+sale"
href="https://www.seekbusiness.com.au/?tracking=sk:main:au:nav:bus"
href="https://www.seekbusiness.com.au/?tracking=sk%3Amain%3Aau%3Anav%3Abus"
>
Business for sale
</a>
Expand Down Expand Up @@ -2730,7 +2730,7 @@ exports[`Footer: should render with locale of AU 1`] = `
<a
class="FooterLink__link"
data-analytics="toolbar:business+for+sale"
href="https://www.seekbusiness.com.au/?tracking=sk:main:au:nav:bus"
href="https://www.seekbusiness.com.au/?tracking=sk%3Amain%3Aau%3Anav%3Abus"
>
Business for sale
</a>
Expand Down Expand Up @@ -3534,7 +3534,7 @@ exports[`Footer: should render with locale of NZ 1`] = `
<a
class="FooterLink__link"
data-analytics="toolbar:business+for+sale"
href="https://www.seekbusiness.co.nz/?tracking=sk:main:nz:nav:bus"
href="https://www.seekbusiness.com.au/?site=nz&tracking=sk%3Amain%3Anz%3Anav%3Abus"
>
Business for sale
</a>
Expand Down
6 changes: 4 additions & 2 deletions react/Footer/data/tools.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,13 +109,15 @@ export const seekSites = [
},
{
name: 'Business for sale',
href: 'https://www.seekbusiness.com.au/?tracking=sk:main:au:nav:bus',
href:
'https://www.seekbusiness.com.au/?tracking=sk%3Amain%3Aau%3Anav%3Abus',
analytics: 'toolbar:business+for+sale',
specificLocale: 'AU'
},
{
name: 'Business for sale',
href: 'https://www.seekbusiness.co.nz/?tracking=sk:main:nz:nav:bus',
href:
'https://www.seekbusiness.com.au/?site=nz&tracking=sk%3Amain%3Anz%3Anav%3Abus',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should line 112 (AU link) also be encoded?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly. I've tried to only change what I've been requested to 😅

analytics: 'toolbar:business+for+sale',
specificLocale: 'NZ'
},
Expand Down