This repository has been archived by the owner on Sep 14, 2021. It is now read-only.
docs(site): Fix playroom routing in ghpages #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattcompiles
approved these changes
Dec 4, 2018
| (async() => { | ||
| if (!fs.existsSync('docs/dist/seek-style-guide')) { // eslint-disable-line no-sync | ||
| await mv('docs/dist', 'docs/seek-style-guide', { mkdirp: true }); | ||
| await mv('docs/seek-style-guide', 'docs/dist/seek-style-guide', { mkdirp: true }); |
There was a problem hiding this comment.
Assuming this is to simulate gh-pages?
There was a problem hiding this comment.
Yeah correct, it simulates the repo nesting on https://seek-oss.github.io/ a.la the base href setting.
markdalgleish
approved these changes
Dec 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately the last PR to add playroom worked everywhere (dev, preview site, & build) but not in ghpages 😞 due to the base href. Refactored the header menu to use a standard anchor for external links, and also prepend the base href to the playroom url.
In order to test this locally i ran up a webserver to preview the ghpages build. Figured i'd add this to help debug issues in the future — no automation, but you can manually run it using
npm run preview-gh-pages.