Set esbuild-register target to node18.20, align targets with supported node version
#1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dbd3e87 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
askoufis
changed the title
esbuild-register target to node18esbuild-register target to node18.20.0
askoufis
changed the title
esbuild-register target to node18.20.0esbuild-register target to node18.20
askoufis
changed the title
esbuild-register target to node18.20esbuild-register target to node18.20, align targets with supported node version
…serslistNodeTarget`
… to satisfy `@ts-check` in `postinstall.js`
askoufis
commented
Nov 8, 2024
| @@ -48,6 +48,7 @@ | |||
| "@tsconfig/node-lts": "^18.12.3", | |||
| "@types/jest": "^29.0.0", | |||
| "@types/node": "^18.19.31", | |||
| "@types/prettier": "^2.7.3", | |||
There was a problem hiding this comment.
prettier's API is used in postinstall.js.
kjots
approved these changes
Nov 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sku targets node 18.20 at a mininum, so
esbuild-registershould target that version too.Have updated the repo's
postinstallscript to generatetargets.jsonwith abrowserslistNodeTargetandesbuildNodeTarget.