Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): Upgrade Less to v3 #190

Merged
merged 3 commits into from
Oct 18, 2018
Merged

fix(deps): Upgrade Less to v3 #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d1dcb30
fix(less): Update less
Oct 17, 2018
c1f8564
fix(less): Update less
Oct 17, 2018
09e1aed
fix(less): Upgrades less
Oct 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
"inquirer": "^6.0.0",
"jest": "^23.4.2",
"kopy": "^8.3.0",
"less": "^2.7.2",
"less": "^3.8.1",
"less-loader": "^4.1.0",
"lodash": "^4.17.10",
"memoizee": "^0.4.14",
Expand Down
4 changes: 2 additions & 2 deletions test/test-cases/braid-design-system/__snapshots__/braid-design-system.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ Object {
._3Zn-PeU{border-radius:4px}
._1sseFqJ{border-style:solid;border-width:1px}
._1d6RKtE{-webkit-box-shadow:0 0 0 1px #2765cf;box-shadow:0 0 0 1px #2765cf}
.mT50rPc{color:#1c1c1c}._1Rsg9w6{color:#fff}._3OSCp5v{color:#e60278}.AsBZy5a{color:green}._1DYv5gu{color:#1c1c1ca1 a1}._3rwI692{color:#2765cf}
._16w04Xz{fill:currentColor}._1srDitw{fill:#2765cf}.hK-SldW{fill:#ccc}._3SkkQl1{fill:#e60278}.q2J3ENx{fill:green}._2WNYdGY{fill:#1c1c1ca1 a1}.QR_XQhw{fill:#fff}
.mT50rPc{color:#1c1c1c}._1Rsg9w6{color:#fff}._3OSCp5v{color:#e60278}.AsBZy5a{color:green}._1DYv5gu{color:#1c1c1ca1}._3rwI692{color:#2765cf}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markdalgleish any idea if this change in the snapshot is meaningful (ie did I just legit ignore a broken test)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First glance, this looks like a broken test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the original snap it appears less was repeating the opacity, maybe as some kind of compatibility issue? I don't think that's a problem if they've dropped that behaviour 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry—didn't realise the summary version wasn't showing me the full diff. It looked like an entire line of CSS had been removed. I see what you mean now 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the result of v3.8.1 adding support for #RRGGBBAA. Highlights an interesting scenario though, snapshots here can change based on internal braid-design-system changes.

._16w04Xz{fill:currentColor}._1srDitw{fill:#2765cf}.hK-SldW{fill:#ccc}._3SkkQl1{fill:#e60278}.q2J3ENx{fill:green}._2WNYdGY{fill:#1c1c1ca1}.QR_XQhw{fill:#fff}
._2tWVdVE{font-family:Helvetica Neue,HelveticaNeue,Helvetica,Arial,sans-serif}
._28lA_OY{font-weight:400}.OFyAM3C{font-weight:600}
._2XfQI3Q{margin-top:0}._1L7e8Uc{margin-top:6px}._2DeEfmd{margin-top:12px}._2BrS2wh{margin-top:18px}._87KrWkV{margin-top:24px}._31oD2hw{margin-top:30px}._3G8Ovpy{margin-top:48px}._2uO0VaK{margin-top:72px}
Expand Down
2 changes: 1 addition & 1 deletion test/test-cases/braid-design-system/braid-design-system.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const path = require('path');
const { promisify } = require('es6-promisify');
const rimrafAsync = promisify(require('rimraf'));
const fs = require('fs').promises;
const fs = require('fs-extra');
const dirContentsToObject = require('../../utils/dirContentsToObject');
const runSkuScriptInDir = require('../../utils/runSkuScriptInDir');
const appDir = path.resolve(__dirname, 'app');
Expand Down
3 changes: 1 addition & 2 deletions test/test-cases/seek-asia-style-guide/seek-asia-style-guide.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
const path = require('path');
const { promisify } = require('es6-promisify');
const rimrafAsync = promisify(require('rimraf'));
const fs = require('fs').promises;
const { F_OK } = require('fs').constants;
const fs = require('fs-extra');
const dirContentsToObject = require('../../utils/dirContentsToObject');
const runSkuScriptInDir = require('../../utils/runSkuScriptInDir');
const appDir = path.resolve(__dirname, 'app');
Expand Down
3 changes: 1 addition & 2 deletions test/test-cases/seek-style-guide/seek-style-guide.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
const path = require('path');
const { promisify } = require('es6-promisify');
const rimrafAsync = promisify(require('rimraf'));
const fs = require('fs').promises;
const { F_OK } = require('fs').constants;
const fs = require('fs-extra');
const dirContentsToObject = require('../../utils/dirContentsToObject');
const runSkuScriptInDir = require('../../utils/runSkuScriptInDir');
const appDir = path.resolve(__dirname, 'app');
Expand Down