feat(configure): Control gitignoring of sku-created config files #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeltaranto
changed the title
markdalgleish
previously approved these changes
Oct 23, 2018
|
Closing temporarily. Will re-open when this PR is merged |
michaeltaranto
dismissed
markdalgleish’s stale review
Changes made. Please re-review
scripts/configure.js
Outdated
| const builds = require('../config/builds'); | ||
|
|
||
| const outputDirs = uniq([ | ||
| ...builds.map( |
There was a problem hiding this comment.
Spread here is unnecessary
There was a problem hiding this comment.
Sleuth 🕵🏻♂️
| yarn.lock | ||
| package-lock.json | ||
| .idea | ||
|
|
||
| # managed by sku |
markdalgleish
approved these changes
Oct 24, 2018
mattcompiles
approved these changes
Oct 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the output/target directory and the bundle report gitignores to be managed by the configure script. This pattern of controlled ignores is going to be adopted more through the typescript support PR.