RFC: Remove BUILDPLATFORM
#1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm pretty split on this one. It should be largely inconsequential for the general case where an engineer is running Apple Silicon locally and building for a Graviton environment, but it has some implications when these platforms are not aligned. Preferring `BUILDPLATFORM`: - Quicker to build when local platform differs from deployment target - Local behaviour is more likely differ from CI - Locally built image may not be deployable during disaster recovery Preferring to hardcode `amd64` or `arm64`: - Slower to build when local platform differs from deployment target - Local behaviour is less likely to differ from CI - Locally built image should be deployable during disaster recovery
🦋 Changeset detectedLatest commit: b3d5821 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
samchungy
approved these changes
Dec 18, 2023
|
Came back around to this and landed on the same conclusion, so I'll get this merged once I write up a changeset, then look at improving guidance in https://seek-oss.github.io/skuba/docs/deep-dives/arm64.html for existing x86 projects. |
Merged
72636c
added a commit
that referenced
this pull request
Mar 18, 2024
* RFC: Refresh ARM64 guide Follows on from #1350. * Do not imply vCurrent is ARM-exclusive Co-authored-by: Aaron Moat <amoat@seek.com.au> * Add a changeset --------- Co-authored-by: Aaron Moat <amoat@seek.com.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pretty split on this one. It should be largely inconsequential for the general case where an engineer is running Apple Silicon locally and building for a Graviton environment, but it has some implications when these platforms are not aligned.
https://docs.docker.com/build/guide/multi-platform/#platform-build-arguments
https://www.docker.com/blog/faster-multi-platform-builds-dockerfile-cross-compilation-guide/
This is my understanding:
Preferring
BUILDPLATFORM:Preferring to hardcode
amd64orarm64:Preferring no
--platform/TARGETPLATFORM:--platformbuild option