Add pnpm command to update snapshot #1647
Merged
+46
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add a new
pnpm test:template:updateSnapshot
scriptWhat it does
It leverages existing
update-template.sh
and adds a-u
option to update snapshot. It will update existing snapshots when running tests intmp-${template}
dir and copy the snapshots toskuba/template
dirWhy
To make it easier to avoid #1646 because I missed it in #1644
Further thoughts
I initially thought to make
pnpm test:template
--updateSnapshot
by default but I am unsure of the existing approach. Assuming that snapshots in template are meant as safeguard for template user and not skuba developers, it might be easier to just have ahusky pre-commit
hook to--updateSnapshot
by default when modifying templates.