Automatically expire footer cache when settings changed #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update links to HTTPS
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
stuzart
requested changes
Jul 7, 2023
app/views/layouts/_footer.html.erb
Outdated
| <% end %> | ||
| <%= link_to 'Funding and Programmes', funding_home_path -%> | | ||
| <% if Seek::Config.funding_link.present? %> | ||
| <a href="<%=Seek::Config.funding_link%>" target="_blank"> |
There was a problem hiding this comment.
this should be changed to link_to (no idea why it was written this way). I don't think link_to automatically adds the noreferrer though. We may need to update all links that open in a new tab.
There was a problem hiding this comment.
i'll just change it to link_to for now, we can think about how to update all external links later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses Rails' cache key generation to detect if settings have changed
Also update Manchester/HITS website links to HTTPS