Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

G-Helper's run-on-log-in task isn't updated if its executable is moved #1410

Closed
Varriount opened this issue Oct 2, 2023 · 3 comments
Closed
Labels
question Further information is requested

Comments

@Varriount
Copy link

NOTE

Bug reports without clear information or scenario to reproduce and logs from %AppData%\GHelper will be closed without answer.
Please respect the time of the developer. Thanks.

Describe the bug
G-Helper will not update its run-on-log-in task (handled by Task Scheduler) if its executable is moved (and it is set to run on login). More specifically, G-Helper will only update its run-on-log-in task if the "Run on Startup" checkbox is un-checked and then re-checked.

Clear scenario to Reproduce
Steps to reproduce the behavior:

  1. Download and run G-Helper on a system with no "G-Helper" task in Task Scheduler.
  2. Modify G-Helper's settings so that it is set to run on log-in.
  3. Exit G-Helper.
  4. Move G-Helper's executable.
  5. Start G-Helper.
  6. Log out.
  7. Log in.
  8. Notice that G-Helper isn't running.

Expected behavior
G-Helper should update its run-on-log-in task when it is starting up and "Run on Startup" is checked.

App Logs
Please include and attach log.txt from [log.txt](https://github.com/seerge/g-helper/files/12786921/log.txt)

Desktop (please complete the following information):

  • OS: Windows 11
  • Asus Zephrus M16

Asus software

  • Armoury Crate (installed, disabled)
  • MyASUS installed
@seerge
Copy link
Owner

seerge commented Oct 2, 2023

@Varriount hello, this is actually intentional

I have noticed that sometimes people download zip with updates and for example can run exe single time directly from zip (resulting running it from temp folder). Or some similar "strange" situations.

Therefore I don't want app to override existing startup job that most probably points at some established exe location ;)

@Varriount
Copy link
Author

It could check that the executable defined by the task actually exists.

seerge added a commit that referenced this issue Oct 3, 2023
@seerge
Copy link
Owner

seerge commented Oct 3, 2023

@Varriount ok, this specific check could be valid

Try this build, it will re-schedule app on startup if current path != scheduled path and if scheduled path doesn't exist

GHelper.zip

@seerge seerge added the question Further information is requested label Oct 3, 2023
@seerge seerge closed this as completed Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants