-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual modes on M16 2023 Mini-LED while HDR is on #2301
Comments
@Sontarr ok, that's a valid reason Try this build P.S. Did one more update, to hide visual modes if laptop screen is OFF (i.e. when you use external monitor and laptop's is turned off or closed) |
@Sontarr this build should have label in a same size as disabled buttons, it should prevent resizing. But actually in my case it auto-resizes correctly every time anyway :) |
@seerge Yeah, when I close and open the window, the height is adjusted, in the old build and the new. But if the window is already open while switching the mode, it gets bigger. Strange. Even with the new build. |
Just a short check: This doesn't happen with 0.161. Its new behavior. |
@Sontarr what UI scaling in windows do you use ? |
125% |
@Sontarr can you check if this build helps ? |
It's still a little bit bigger when HDR is on, but only a few pixels. Almost unrecognizable. It's okay, I think. 125% or 150% doesn't make a difference. |
@Sontarr alternatively I can just keep whole UI as is (i.e. show dropdowns), but just skip actual action if HDR is on |
Its strange. If I move the mouse over the GPU mode buttons, the help text of the buttons is shown and the window shrinks a few pixels. 🤪 Sure, disabling the dropdowns is an option. |
@Sontarr can you check if this build improves anything ? |
@seerge Perfect! |
@Sontarr I have changed UI one more time, so label will appear just on top of visual modes dropdowns. It won't trigger form resizing at all, so should always look correct Can you check if this build behaves correctly for you ? |
@seerge Yes, works fine. Came around to test it with an external monitor. Works as expected too. 👍 |
Great, thanks for testing. It's already live in 0.163 |
If possible, and if you don't mind. At least provide a way to keep visual modes available while still using HDR as I have some use cases where I need to use both features HDR and visual modes at the same time. Obviously, Armoury Crate wouldn't allow this mode to happen, but previously, ghelper allowed it, and I would like to have this back. |
@THEBOSS619 but do visual modes work for you if HDR is on? or it screws up colors as for @Sontarr ? |
@seerge Yes, it does work for me and makes a difference in color tone while using both HDR and visual modes. It doesn't screw up color for me. |
@THEBOSS619 this build should allow clicking on label (saying it's not available) to remove it and enable visual modes again |
@seerge thank you so much! it works! and I love the idea too! |
@Sontarr can you try if this build STILL detects HDR correctly on your device ? And post a log from it |
@Sontarr oke, thanks Delay in UI is not related to changes anyhow :) just switching to Eco sometimes takes time, but this is how things work in bios |
@Sontarr @THEBOSS619 all changes are live in 0.164 |
Rules
What's wrong?
When I change the visual mode, the color temp or the gamut while HDR is switched on, the resulting colors don't look correct. Cinema is extremely blue, Eyecare very orange and the gamuts just look washed out.
Now I installed Armoury Crate to look up a few translations and noticed that the whole Game Visual section is not accessible while HDR is on. Uninstalled Armoury Crate directly afterwards.
I believe at least the M16 Mini-LED machines shouldn't be able to change visual mode, color temp and gamut while HDR is on.
How to reproduce the bug?
Logs
log.txt
Device and Model
Asus Zephyrus M16 2023 GU604VY
Additional information.
No response
Armoury Crate
Uninstalled
Asus Services
None
Version
0.161
OS
Windows 11 Home 23H2
The text was updated successfully, but these errors were encountered: