Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual modes on M16 2023 Mini-LED while HDR is on #2301

Closed
2 tasks done
Sontarr opened this issue Mar 26, 2024 · 25 comments
Closed
2 tasks done

Visual modes on M16 2023 Mini-LED while HDR is on #2301

Sontarr opened this issue Mar 26, 2024 · 25 comments
Labels
question Further information is requested

Comments

@Sontarr
Copy link

Sontarr commented Mar 26, 2024

Rules

  • I made myself familiar with the Readme, FAQ and Troubleshooting.
  • I understand that, if insufficient information or no app logs will be provided, my issue will be closed without an answer.

What's wrong?

When I change the visual mode, the color temp or the gamut while HDR is switched on, the resulting colors don't look correct. Cinema is extremely blue, Eyecare very orange and the gamuts just look washed out.

Now I installed Armoury Crate to look up a few translations and noticed that the whole Game Visual section is not accessible while HDR is on. Uninstalled Armoury Crate directly afterwards.

I believe at least the M16 Mini-LED machines shouldn't be able to change visual mode, color temp and gamut while HDR is on.

Screenshot 2024-03-26 214209

How to reproduce the bug?

  1. turn HDR on
  2. try to change visual mode, color temp and gamut

Logs

log.txt

Device and Model

Asus Zephyrus M16 2023 GU604VY

Additional information.

No response

Armoury Crate

Uninstalled

Asus Services

None

Version

0.161

OS

Windows 11 Home 23H2

@seerge
Copy link
Owner

seerge commented Mar 26, 2024

@Sontarr ok, that's a valid reason

Try this build

GHelper.zip

P.S. Did one more update, to hide visual modes if laptop screen is OFF (i.e. when you use external monitor and laptop's is turned off or closed)

@Sontarr
Copy link
Author

Sontarr commented Mar 27, 2024

@seerge It works when changing HDR via Win+Alt+B hotkey and when the HDR is automatically switched on/off when switching from battery to plugged in and back. Will test the external monitor later.

It does however not always get the height difference in the windows right.

log.txt

Screenshot 2024-03-27 083002
Screenshot 2024-03-27 082950

@seerge
Copy link
Owner

seerge commented Mar 27, 2024

@Sontarr this build should have label in a same size as disabled buttons, it should prevent resizing. But actually in my case it auto-resizes correctly every time anyway :)

GHelper.zip

@seerge seerge added the question Further information is requested label Mar 27, 2024
@Sontarr
Copy link
Author

Sontarr commented Mar 27, 2024

@seerge Yeah, when I close and open the window, the height is adjusted, in the old build and the new. But if the window is already open while switching the mode, it gets bigger. Strange. Even with the new build.

Screenshot 2024-03-27 100025

@Sontarr
Copy link
Author

Sontarr commented Mar 27, 2024

Just a short check: This doesn't happen with 0.161. Its new behavior.

@seerge
Copy link
Owner

seerge commented Mar 27, 2024

@Sontarr what UI scaling in windows do you use ?

@Sontarr
Copy link
Author

Sontarr commented Mar 27, 2024

125%

@seerge
Copy link
Owner

seerge commented Mar 27, 2024

@Sontarr can you check if this build helps ?
GHelper.zip

@Sontarr
Copy link
Author

Sontarr commented Mar 27, 2024

It's still a little bit bigger when HDR is on, but only a few pixels. Almost unrecognizable. It's okay, I think.

125% or 150% doesn't make a difference.

seerge added a commit that referenced this issue Mar 27, 2024
@seerge
Copy link
Owner

seerge commented Mar 27, 2024

@Sontarr alternatively I can just keep whole UI as is (i.e. show dropdowns), but just skip actual action if HDR is on

@Sontarr
Copy link
Author

Sontarr commented Mar 27, 2024

Its strange. If I move the mouse over the GPU mode buttons, the help text of the buttons is shown and the window shrinks a few pixels. 🤪

Sure, disabling the dropdowns is an option.

@seerge
Copy link
Owner

seerge commented Mar 27, 2024

@Sontarr can you check if this build improves anything ?
GHelper.zip

@Sontarr
Copy link
Author

Sontarr commented Mar 27, 2024

@seerge Perfect!

@seerge
Copy link
Owner

seerge commented Mar 27, 2024

@Sontarr I have changed UI one more time, so label will appear just on top of visual modes dropdowns. It won't trigger form resizing at all, so should always look correct

Can you check if this build behaves correctly for you ?

GHelper.zip

@Sontarr
Copy link
Author

Sontarr commented Mar 27, 2024

@seerge Yes, works fine.

Came around to test it with an external monitor. Works as expected too. 👍

@seerge
Copy link
Owner

seerge commented Mar 27, 2024

Great, thanks for testing. It's already live in 0.163

@seerge seerge closed this as completed Mar 27, 2024
@THEBOSS619
Copy link

If possible, and if you don't mind. At least provide a way to keep visual modes available while still using HDR as I have some use cases where I need to use both features HDR and visual modes at the same time.

Obviously, Armoury Crate wouldn't allow this mode to happen, but previously, ghelper allowed it, and I would like to have this back.

@seerge
Copy link
Owner

seerge commented Mar 27, 2024

@THEBOSS619 but do visual modes work for you if HDR is on? or it screws up colors as for @Sontarr ?

@THEBOSS619
Copy link

@THEBOSS619 but do visual modes work for you if HDR is on? or it screws up colors as for @Sontarr ?

@seerge Yes, it does work for me and makes a difference in color tone while using both HDR and visual modes. It doesn't screw up color for me.

@seerge
Copy link
Owner

seerge commented Mar 27, 2024

@THEBOSS619 this build should allow clicking on label (saying it's not available) to remove it and enable visual modes again

GHelper.zip

@THEBOSS619
Copy link

THEBOSS619 commented Mar 27, 2024

@THEBOSS619 this build should allow clicking on label (saying it's not available) to remove it and enable visual modes again

GHelper.zip

@seerge thank you so much! it works! and I love the idea too!
Animation

@seerge
Copy link
Owner

seerge commented Mar 27, 2024

@Sontarr can you try if this build STILL detects HDR correctly on your device ?

GHelper.zip

And post a log from it

@Sontarr
Copy link
Author

Sontarr commented Mar 28, 2024

@seerge It works.

log.txt

The change from plugged in to battery seems to take unusually long if the G-Helper main window is open. The OSD is there for nearly 10 sec. (Changing from Balanced to Silent, Standard to Eco, 240Hz to 60Hz, HDR Multizone to SDR Singlezone)

@seerge
Copy link
Owner

seerge commented Mar 28, 2024

@Sontarr oke, thanks

Delay in UI is not related to changes anyhow :) just switching to Eco sometimes takes time, but this is how things work in bios

@seerge
Copy link
Owner

seerge commented Mar 28, 2024

@Sontarr @THEBOSS619 all changes are live in 0.164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants