Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow manual disabling of all functions related to the GPU #3360

Closed
wants to merge 1 commit into from

Conversation

yinyue200
Copy link
Contributor

I noticed that when the software starts on my device, it throws some exceptions that are caught and properly handled. Despite my device not having any dGPU, the AsusFan.GPU endpoint still exists, which causes an unnecessary GPU panel to appear on my device. This PR aims to minimize exceptions during the normal execution of the software to slightly improve performance. More importantly, it will allow users to manually hide the GPU panel and automatically hide these related panels on devices that are known to lack a dGPU.

@seerge
Copy link
Owner

seerge commented Nov 10, 2024

@yinyue200 hello,

For Matrix checking, i kind of agree. But I was thinking about just setting a list of models that do have matrix (as it's mainly G14, M16 and few others) , instead of opposite. Even tho it's just a quick one time check for an USB device on app start.

But for AmdGpuControl - it's needed for iGPU readings as well :) (and this is lots of devices with AMD CPUs and Rog Ally)

@yinyue200 yinyue200 force-pushed the allowdisablegpu branch 2 times, most recently from fd95797 to 26222d8 Compare November 10, 2024 22:26
@yinyue200
Copy link
Contributor Author

Thank you! It has now been adjusted so that the configuration file needs to be manually modified to disable it. This provides a way for users who don't need the suite of GPU features to hide GPU-related UI.

@yinyue200 yinyue200 changed the title Allow manual disabling of all functions related to the dGPU Allow manual disabling of all functions related to the GPU Nov 10, 2024
seerge added a commit that referenced this pull request Nov 11, 2024
@seerge
Copy link
Owner

seerge commented Nov 11, 2024

@yinyue200 ok, even tho I think it's a bit an overkill, I have added an option to skip nvidia / amd driver checks all together, and also hardcoded your model automatically.

Mainly to hide GPU section in the UI. But keep in mind, that now you won't be able to see second fan speed that your device seem to have ?

Also your if (!Adl2.Load() || AppConfig.NoGpu()) would still check for AMD driver most likely, as ADL2 comes first in a condition :) So I have swapped them

seerge added a commit that referenced this pull request Nov 11, 2024
seerge added a commit that referenced this pull request Nov 11, 2024
@yinyue200 yinyue200 closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants