feat(compose): docker secrets for postgres env#2166
feat(compose): docker secrets for postgres env#2166benja1006 wants to merge 2 commits intoseerr-team:developfrom
Conversation
… parameters added support for using docker secrets to set the postgres username, password and database names re seerr-team#2144
|
I wanted to check in on the re-use of a the stringOrReadFileFromEnv() function. I had to modify it slightly to avoid returning a Buffer. To my knowledge, cert files shouldn't contain non-utf-8 encodable characters, so this shouldn't break anything. Alternatively, I could create a duplicate function if that would be preferred. If this were the route taken, I would include the trim inside which would make the resultant code a little nicer. The trim is there to deal with newlines at the end of the file. I'm also open to recommendations on how I should comment the example compose.posgres.yaml |
|
Hey @benja1006 :) There’s a similar feature for API Key #2150 that aims to support systemd-credentials (which is similar to Docker secrets). We’ll work on the API key first and ensure compatibility with both Docker and systemd. After that, we can reuse the same logic for your PR here. Feel free to comment on this PR if you have any input to share! :) |
|
Hey @benja1006, since #2150 has been inactive for a while, I’ll mark it as blocked. We can handle the work here instead let me know if that works for you. Could you implement it along the lines of my comment here? |
|
Hey @M0NsTeRRR I would be happy to take a stab at that. Should be a pretty easy adjustment |
Description
Added support for using docker secrets to set the postgres username, password and database names
Screenshot (if UI-related)
To-Dos
pnpm buildpnpm i18n:extractIssues Fixed or Closed