Skip to content

Added objc support. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2023
Merged

Added objc support. #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc091f5
Added objc support.
bsneed Mar 27, 2023
e79f1fe
Updated example project with the correct analytics-swift version.
bsneed Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Example/BasicExample/BasicExample.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,7 +609,7 @@
repositoryURL = "https://github.com/segmentio/analytics-swift";
requirement = {
kind = upToNextMajorVersion;
minimumVersion = 1.1.2;
minimumVersion = 1.4.0;
};
};
823B068B28E6199200E8899C /* XCRemoteSwiftPackageReference "mixpanel-swift" */ = {
Expand Down
4 changes: 2 additions & 2 deletions Example/BasicExample/BasicExample.xcworkspace/xcshareddata/swiftpm/Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ let package = Package(
.package(
name: "Segment",
url: "https://github.com/segmentio/analytics-swift.git",
from: "1.1.2"
from: "1.4.0"
),
.package(
name: "Mixpanel",
Expand Down
7 changes: 7 additions & 0 deletions Sources/SegmentMixpanel/MixpanelDestination.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,13 @@ import Foundation
import Segment
import Mixpanel


@objc(SEGMixpanelDestination)
public class ObjCSegmentMixpanel: NSObject, ObjCDestination, ObjCDestinationShim {
public func instance() -> DestinationPlugin { return MixpanelDestination() }
}


public class MixpanelDestination: DestinationPlugin, RemoteNotifications {
public let timeline = Timeline()
public let type = PluginType.destination
Expand Down