This repository was archived by the owner on Apr 24, 2024. It is now read-only.
Fix for potential deadlock #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2prateek
reviewed
Jun 25, 2018
| @@ -243,7 +243,7 @@ internal BlockingRequestHandler(Client client, TimeSpan timeout) | |||
| // If status code is greater than 500 and less than 600, it indicates server error | |||
| // Error code 429 indicates rate limited. | |||
| // Retry uploading in these cases. | |||
| Task.Delay(backoff).Wait(); | |||
| await Task.Delay(backoff); | |||
There was a problem hiding this comment.
is there a mimimum version of .net this must be used with? wondering if there's a chance of breaking compatibility?
There was a problem hiding this comment.
Minimum version for async/await is NET 4.5. However, this line is inside #else preprocessor block for all targets except NET 3.5 (Thread.Sleep(backoff) is used there). For portable assembly target is NET 4.5.1.
f2prateek
approved these changes
Jul 5, 2018
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here creating separate PR for await fix.