bugfix: make queryID optional in Algolia insights destination action #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-ayoub-segment
approved these changes
Jun 20, 2023
|
Hi @joe-ayoub-segment how often do changes to this codebase get deployed? |
|
Hi @wwalser - every Tuesday for Cloud Mode Destinations. However we delayed the deploy because the company had a day off Monday. |
|
Hi @wwalser this PR has been deployed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Algolia Insights destination was added here: #975 and merged here: #1027.
In those additional, queryID was mistakenly made required which is not the case in the downstream API (Algolia Insights). This PR fixes that problem.
Testing
The snapshot tests seem to test this without a query ID. I've added additional unit tests that ensure the queryID is forwarded as expected when it is present.
I've booted up my local environment and tested this manually as well. 👍