LaunchDarkly: add enable_batching field to Audiences destination action. #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kelly Hofmann <khofmann@launchdarkly.com> Co-authored-by: Clifford Tawiah <ctawiah@launchdarkly.com> Co-authored-by: Kelly Hofmann <55991524+k3llymariee@users.noreply.github.com> Co-authored-by: Cliff Tawiah <82856282+ctawiah@users.noreply.github.com> Co-authored-by: Molly <molly.jones@launchdarkly.com>
ldhenry
changed the title
joe-ayoub-segment
approved these changes
Sep 6, 2023
joe-ayoub-segment
approved these changes
Sep 8, 2023
|
hi @ldhenry this PR has been deployed. |
wpride
pushed a commit
to wpride/action-destinations
that referenced
this pull request
Oct 12, 2023
Co-authored-by: Kelly Hofmann <khofmann@launchdarkly.com> Co-authored-by: Clifford Tawiah <ctawiah@launchdarkly.com> Co-authored-by: Kelly Hofmann <55991524+k3llymariee@users.noreply.github.com> Co-authored-by: Cliff Tawiah <82856282+ctawiah@users.noreply.github.com> Co-authored-by: Molly <molly.jones@launchdarkly.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
enable_batchingfield to LaunchDarkly Audiences'syncAudiencesaction. This was done to override the default value of false because batching should be enabled in most cases. I decided to make this change after chatting with @joe-ayoub-segment.Testing
I can see the new field when testing locally.