Map product_id for a Product #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsneed
approved these changes
Mar 30, 2021
prayansh
reviewed
Mar 30, 2021
| @@ -422,7 +423,7 @@ public String name() { | |||
| } | |||
|
|
|||
| public String id() { | |||
| return getString(ID_KEY); | |||
| return getString(ID_KEY) != null ? getString(ID_KEY) : getString(PRODUCT_ID_KEY); | |||
There was a problem hiding this comment.
question: do u think we should give first preference to product_id and then fall back to id or vice versa?
There was a problem hiding this comment.
My thinking was to give preference to id over product_id. This should not introduce any changes if a customer is sending both id and product_id. If a customer is sending both values you'd expect those values to be the same but you never know!
prayansh
reviewed
Mar 30, 2021
| @@ -197,5 +197,9 @@ class PropertiesTest { | |||
| assertThat(product.name()).isNull() | |||
| product.putName("name") | |||
| assertThat(product.name()).isEqualTo("name") | |||
|
|
|||
| product.remove("id") | |||
prayansh
approved these changes
Mar 30, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per below we do not check to see if a
product_idis present and only map forid#746