move writekey to body #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didiergarcia
approved these changes
Nov 30, 2022
| @@ -139,6 +142,7 @@ static synchronized AnalyticsContext create( | |||
| analyticsContext.putNetwork(context); | |||
| analyticsContext.putOs(); | |||
| analyticsContext.putScreen(context); | |||
| analyticsContext.putTelemetry(); | |||
There was a problem hiding this comment.
yah. I thought about this too. but seems like the "put" functions are grouped by functionality (network, os, app, library, etc). the instanceId is added specifically for telemetry. we might have more fields to support telemetry in the future. thus, thought it's better to put it into a new group
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
writeKeyfrom auth header to batch body