Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Screen tracking doesn't always produce desired name for UITabBarController and UISplitViewController #654

Closed
markst opened this issue Dec 21, 2016 · 3 comments · Fixed by #771
Closed

Screen tracking doesn't always produce desired name for UITabBarController and UISplitViewController #654

markst opened this issue Dec 21, 2016 · 3 comments · Fixed by #771
Labels
improvement jira

Comments

@markst
Copy link

markst commented Dec 21, 2016

It seems that the output of seg_topViewController doesn't always pick the right view top view controller especially for instances when we have nested child view controllers.

Is this particular case we have our navigation controller nested within a RootViewController which results in all our screen tracking events being called: "Root"

Happy to either PR to produce better results, or perhaps inclined to not use provided recordScreenViews view controller swizzler.

Thanks.
@f2prateek
Copy link
Contributor

Happy to accept a PR to improve the behavior. We want automatic screen tracking wherever possible, but it definitely comes with the understanding that it might not work for every view configuration, in which case manually making screen calls is always an option.

bfernandesbfs added a commit to bfernandesbfs/analytics-ios that referenced this issue Jan 28, 2017
@bfernandesbfs
Screen tracking doesn't always produce desired name. Fix for issue se…
c72ab33 
…gmentio#654
@f2prateek f2prateek changed the title Screen tracking doesn't always produce desired name Screen tracking doesn't always produce desired name for UITabBarController and UISplitViewController Nov 23, 2017
@f2prateek
Copy link
Contributor

Tracking internally in JIRA — https://segment.atlassian.net/browse/LIB-132

@humblehacker humblehacker mentioned this issue Jul 25, 2018
Merged
@bsneed
Copy link
Contributor

bsneed commented May 6, 2020

This has been resolved in #884

@bsneed bsneed closed this as completed May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement jira
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Custom name/properties for auto screen reporting humblehacker/analytics-ios
3 participants
@bsneed @markst @f2prateek