Exclude files from backup #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @wcjohnson11 @tonyxiao @ladanazita for review |
|
and @RetepV as well! |
|
lgtm! 👍 |
| @@ -102,6 +102,9 @@ - (id)initWithAnalytics:(SEGAnalytics *)analytics | |||
| dispatch_sync(dispatch_get_main_queue(), ^{ | |||
| self.flushTimer = [NSTimer scheduledTimerWithTimeInterval:30.0 target:self selector:@selector(flush) userInfo:nil repeats:YES]; | |||
| }); | |||
| [self addSkipBackupAttributeToItemAtPath:self.userIDURL]; | |||
There was a problem hiding this comment.
what about anonymousIdURL?
There was a problem hiding this comment.
oh good catch, I just copied the ones here https://github.com/segmentio/analytics-ios/blob/46a56f6fe0cd6866f3b6fac370d7815fc341aad0/Analytics/Classes/Internal/SEGSegmentIntegration.m#L498-L500 but look we're missing anonymousID there
f2prateek
added a commit
that referenced
this pull request
Jun 30, 2016
f2prateek
added a commit
that referenced
this pull request
Jul 10, 2016
f2prateek
added a commit
that referenced
this pull request
Jul 10, 2016
* Carthage Support * Initialize flush timer on the main thread. * Replace Foundation import with UIKit import (#563) * Track Campaign Data (#557) * Update contributing docs (#564) * Limit Queue size to 1000 (#565) * Reformat (#566) * Exclude files from backup (#567) * Add tvOS Support (#572) * reformat * Track Deep Links (#573) * Fix CI (#574) * Use vanilla xcodebuild in CI * use xcpretty in ci * Update context object with referrer information (#575) * use 3.2.6 in sample
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #537