tvOS support #571

justindhill · 2016-07-01T16:56:35Z

No description provided.

tvOS targets

- Fixed a bug that caused an incomplete set of traits to be persisted to NSUserDefaults - On tvOS, switched the order of loading of traits and the queue so it's attempted from the file first, then NSUserDefaults - Updated the Podspec - Bumped the version to 3.2.6 - Added a tvOS deployment target version (9.0)

NSUserDefaults to only NSUserDefaults on tvOS

f2prateek · 2016-07-01T16:59:03Z

Hey @justindhill - looks like the compilation works fine but the Podspec does not validate. you can run make lint locally to see the output yourself.

https://cloudup.com/cfQaMXWRBEO

pod lib lint

 -> Analytics (3.2.5)
    - WARN  | [tvOS] xcodebuild:  /Users/prateek/dev/src/github.com/segmentio/analytics-ios/Analytics/Classes/Internal/SEGAnalyticsRequest.m:34:48: warning: 'initWithRequest:delegate:startImmediately:' is deprecated: first deprecated in tvOS 9.0 - Use NSURLSession (see NSURLSession.h) [-Wdeprecated-declarations]
    - NOTE  | [tvOS] xcodebuild:  /Applications/Xcode.app/Contents/Developer/Platforms/AppleTVSimulator.platform/Developer/SDKs/AppleTVSimulator9.2.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURLConnection.h:117:1: note: 'initWithRequest:delegate:startImmediately:' has been explicitly marked deprecated here
    - WARN  | [tvOS] xcodebuild:  /Users/prateek/dev/src/github.com/segmentio/analytics-ios/Analytics/Classes/Internal/SEGLocation.m:38:17: warning: method definition for 'startUpdatingLocation' not found [-Wincomplete-implementation]
    - NOTE  | [tvOS] xcodebuild:  /Users/prateek/dev/src/github.com/segmentio/analytics-ios/Analytics/Classes/Internal/SEGLocation.h:18:1: note: method 'startUpdatingLocation' declared here
    - WARN  | [tvOS] xcodebuild:  /Users/prateek/dev/src/github.com/segmentio/analytics-ios/Analytics/Classes/Internal/SEGSegmentIntegration.m:649:12: warning: unused variable 'url' [-Wunused-variable]

[!] Analytics did not pass validation, due to 3 warnings (but you can use `--allow-warnings` to ignore them).
You can use the `--no-clean` option to inspect any issue.
make: *** [lint] Error 1

Some of these are actually the same warnings I was stuck at last time I looked into this #509 (comment). The good thing is there are no errors now, just warnings!

So if we can fix the warnings that'd be great. Additionaly I'd like to do some manual testing on tvOS for a sanity check as well.

justindhill · 2016-07-01T17:08:39Z

Hey @f2prateek, resolved all but one of the linting errors. The last one is caused by the use of NSURLConnection in SEGSegmentIntegration. You'll need to switch to using NSURLSession to resolve that one.

justindhill · 2016-07-01T17:09:43Z

However, that one is a warning and can be resolved at your leisure.

f2prateek · 2016-07-01T17:12:56Z

@justindhill Thanks, we can take care of that separately- we do have an open issue for migrating to NSUrlSession but haven't had time to tackle it.

Do you know if it's possible to have CocoaPods ignore a specific error (other than supressing all with --allow-warnings)?

justindhill · 2016-07-01T17:20:34Z

You can suppress warning emissions within a particular block of code using the preprocessor.

#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"

// code that touches deprecated APIs here

#pragma clang diagnostic pop

f2prateek · 2016-07-01T17:32:48Z

Analytics/Classes/Internal/SEGSegmentIntegration.m

    [self.location startUpdatingLocation];
+#endif


I think we might want to move this lower down - to right before return [context copy];?

I don't know that I agree. CoreLocation is still available on tvOS, as well as CLLocationManager, but it doesn't provide periodic updates like it does on iOS. Presumably, this is because Apple doesn't anticipate the device moving while it's in use. 😜

Ah I see, that makes sense!

f2prateek · 2016-07-01T17:37:02Z

We'll want to remove this entire block:

// Check for previous queue/track data in NSUserDefaults and remove if present
         [self dispatchBackground:^{
             if ([[NSUserDefaults standardUserDefaults] objectForKey:SEGQueueKey]) {
                 [[NSUserDefaults standardUserDefaults] removeObjectForKey:SEGQueueKey];
             }
             if ([[NSUserDefaults standardUserDefaults] objectForKey:SEGTraitsKey]) {
                 [[NSUserDefaults standardUserDefaults] removeObjectForKey:SEGTraitsKey];
             }
         }];

justindhill · 2016-07-01T17:39:42Z

Probably only want to remove it on tvOS, right? I guess the purpose of it was to flush data from NSUserDefaults after you rolled back to file-based storage.

f2prateek · 2016-07-01T17:45:06Z

Analytics/Classes/Internal/SEGSegmentIntegration.m

@@ -586,16 +611,26 @@ - (void)applicationWillTerminate
 - (NSMutableArray *)queue
 {
    if (!_queue) {
+#if TARGET_OS_TV
+        _queue = [[NSUserDefaults standardUserDefaults] objectForKey:SEGQueueKey];


Hey @justindhill , this will need to be _queue = [[NSUserDefaults standardUserDefaults] objectForKey:SEGQueueKey]; ?: [[NSMutableArray alloc] init];. Without that, the queue is always nil since nothing has been stored for that key, and none of the payloads are added to the queue, as a result of which nothing is persisted or uploaded.

Ah, good catch

f2prateek · 2016-07-01T17:46:20Z

@justindhill Yup that was indeed the purpose. Let's remove those LOC just from tvOS for now.

f2prateek · 2016-07-01T17:47:03Z

Analytics/Classes/Internal/SEGSegmentIntegration.m

    return _queue;
 }

 - (NSMutableDictionary *)traits
 {
    if (!_traits) {
+#if TARGET_OS_TV
+        _traits = [[NSUserDefaults standardUserDefaults] objectForKey:SEGTraitsKey];


Same as for the queue, this should fallback to [[NSMutableDictionary alloc] init]

_traits = [[NSUserDefaults standardUserDefaults] objectForKey:SEGTraitsKey] ?: [[NSMutableDictionary alloc] init];

f2prateek · 2016-07-01T17:57:26Z

I tested this with the ?: [[NSMutableDictionary alloc] init] fallbacks and removing the code that was clearing SEGQueueKey and SEGTraitsKey and with those changes everything looked to be working fine!

justindhill · 2016-07-01T17:58:19Z

Great, I made those changes in f9eddea!

f2prateek · 2016-07-01T18:27:06Z

Analytics/Classes/Internal/SEGSegmentIntegration.m

@@ -496,6 +525,8 @@ - (void)reset
    [self dispatchBackgroundAndWait:^{
        [[NSUserDefaults standardUserDefaults] setValue:nil forKey:SEGUserIdKey];
        [[NSUserDefaults standardUserDefaults] setValue:nil forKey:SEGAnonymousIdKey];
+        [[NSUserDefaults standardUserDefaults] setValue:@[] forKey:SEGQueueKey];


Should this and the line below be only on tvOS as well?

I think so, yes.

instead of nil - When resetting, only remove storage files when we are not on tvOS - When retrieving collection objects from NSUserDefaults, make a mutable copy, as all collections retrieved from NSUserDefaults are immutable

f2prateek · 2016-07-01T18:54:10Z

Thanks, tested manually and merged in #572

justindhill added 6 commits June 30, 2016 13:44

- Re-added NSUserDefaults persistence for traits and the event queue on

748f943

tvOS targets

- Bumped version in Podspec back down to 3.2.5

e29864c

- Upped the Xcode version in the Travis config

c3b9668

- Changed storage mechanism for traits + queue + ids from File +

89d012e

NSUserDefaults to only NSUserDefaults on tvOS

Merge remote-tracking branch 'origin/dev' into tvos-support

db5c8d4

justindhill mentioned this pull request Jul 1, 2016

tvOS support #570

Closed

- Resolve a few CocoaPods linting errors

1441c80

f2prateek reviewed Jul 1, 2016
View reviewed changes

- Updates based on pr feedback

f9eddea

f2prateek reviewed Jul 1, 2016
View reviewed changes

f2prateek mentioned this pull request Jul 1, 2016

Add tvOS Support #572

Merged

f2prateek closed this Jul 1, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tvOS support #571

tvOS support #571

justindhill commented Jul 1, 2016

f2prateek commented Jul 1, 2016 •

edited

Loading

justindhill commented Jul 1, 2016

justindhill commented Jul 1, 2016

f2prateek commented Jul 1, 2016

justindhill commented Jul 1, 2016

f2prateek Jul 1, 2016

justindhill Jul 1, 2016

f2prateek Jul 1, 2016

f2prateek commented Jul 1, 2016

justindhill commented Jul 1, 2016

f2prateek Jul 1, 2016

justindhill Jul 1, 2016

f2prateek commented Jul 1, 2016

f2prateek Jul 1, 2016

f2prateek commented Jul 1, 2016

justindhill commented Jul 1, 2016

f2prateek Jul 1, 2016 •

edited

Loading

justindhill Jul 1, 2016

f2prateek commented Jul 1, 2016

tvOS support #571

tvOS support #571

Conversation

justindhill commented Jul 1, 2016

f2prateek commented Jul 1, 2016 • edited Loading

justindhill commented Jul 1, 2016

justindhill commented Jul 1, 2016

f2prateek commented Jul 1, 2016

justindhill commented Jul 1, 2016

f2prateek Jul 1, 2016

Choose a reason for hiding this comment

justindhill Jul 1, 2016

Choose a reason for hiding this comment

f2prateek Jul 1, 2016

Choose a reason for hiding this comment

f2prateek commented Jul 1, 2016

justindhill commented Jul 1, 2016

f2prateek Jul 1, 2016

Choose a reason for hiding this comment

justindhill Jul 1, 2016

Choose a reason for hiding this comment

f2prateek commented Jul 1, 2016

f2prateek Jul 1, 2016

Choose a reason for hiding this comment

f2prateek commented Jul 1, 2016

justindhill commented Jul 1, 2016

f2prateek Jul 1, 2016 • edited Loading

Choose a reason for hiding this comment

justindhill Jul 1, 2016

Choose a reason for hiding this comment

f2prateek commented Jul 1, 2016

f2prateek commented Jul 1, 2016 •

edited

Loading

f2prateek Jul 1, 2016 •

edited

Loading