Swift 4 support and general build setting updates #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build for all architectures cause test compilation to unnecessarily fail We only test on Simulator on CI
Codecov Report
@@ Coverage Diff @@
## master #741 +/- ##
==========================================
+ Coverage 87.18% 87.77% +0.58%
==========================================
Files 36 36
Lines 2552 2552
Branches 176 178 +2
==========================================
+ Hits 2225 2240 +15
+ Misses 321 307 -14
+ Partials 6 5 -1 |
Closed
f2prateek
approved these changes
Dec 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.