Add missing context.device.type field required for Kochava integration. #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fathyb
approved these changes
Apr 11, 2019
f2prateek
approved these changes
Apr 11, 2019
|
Hey @fathyb @f2prateek any news on when this is gonna be released? |
Serheo
pushed a commit
to fubotv/analytics-ios
that referenced
this pull request
Aug 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes issue 38 in React Native SDK segmentio/analytics-react-native#38
According to Kochava destination docs (https://segment.com/docs/destinations/kochava/#getting-started),
context.device.type(has value of ‘ios’ or ‘android’),context.device.advertising_id(IDFA on iOS and adID on Android) andcontext.device.idare required in all calls to Kochava.context.device.typewas not being collected, and this fixes data not being shown in Kochava.