Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken .clang-format symlink #812

Merged
merged 1 commit into from
Apr 19, 2019
Merged

Conversation

tallpants
Copy link
Contributor

@tallpants tallpants commented Mar 12, 2019

What does this PR do?
Removes the broken .clang-format symlink.

How should this be manually tested?
Nope, but you might need to commit a real .clang-format file.

Any background context you want to provide?
It was a symlink to a file on one of the dev's local machines, so there's really no reason at all to have it here. If you insist on having a .clang-format file in the repo we ought to commit a real one.

What are the relevant tickets?
No tickets.

Questions:

  • Does the docs need an update? -- No
  • Are there any security concerns? -- No
  • Do we need to update engineering / success? -- No

@f2prateek
Copy link
Contributor

This seems to break the CI build https://circleci.com/gh/segmentio/analytics-ios/5690

@tallpants
Copy link
Contributor Author

@f2prateek could you commit the real .clang-format file to this branch? I think you have permission to push commits to it since you're a maintainer.

@tallpants
Copy link
Contributor Author

I think that should fix the CI build.

@f2prateek
Copy link
Contributor

Looks like the CI is still broken?

For reference, here's the file I had used https://github.com/square/spacecommander/blob/master/.clang-format

@f2prateek
Copy link
Contributor

Seems like maybe we should use it via a submodule (https://github.com/square/spacecommander#details)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants