Fixed a crash in the file storage #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g old SDK version
bsneed
approved these changes
Apr 23, 2020
|
@arietis thanks so much for this!! |
Merged
bsneed
added a commit
that referenced
this pull request
May 12, 2020
* Add name and properties to auto screen reporting * Make seg_topViewController handle tab and custom container VCs * Simplify SEGScreenReporting protocol Inspired by comments from @f2prateek, simplify the the `SEGScreenReporting` protocol to replace the name and properties fields with a single method (`seg_trackScreen`) that can be implemented when screen tracking for a specific view controller that needs a custom name, properties, or options. * Update Nimble to build with Xcode 10.2 * Add tests for seg_topViewController * fixed a crash in file storage when trying to get a string stored using old SDK version (#880) * Fixed issue where build/version were removed from Application Opened events from background state. * Publish filenames used for data storage (#865) * Remove tvos test from scheme setup. * Fixed selector reference. * Removed unused code. Co-authored-by: David Whetstone <david@humblehacker.com> Co-authored-by: Sergei Guselnikov <arietis@users.noreply.github.com> Co-authored-by: Brandon Sneed <brandon.sneed@segment.com> Co-authored-by: Błażej Biesiada <bejo@users.noreply.github.com>
kevinfarst-earnin
added a commit
to activehours/analytics-ios
that referenced
this pull request
Jun 10, 2020
* adding “name” field to payload;updated nimble to version 7.3.4 * Fix GCD mutual dependency (segmentio#785) * Add iOS Backgrounded Event. (segmentio#831) * Add iOS Backgrounded Event. * Bump Xcode CI version * Bump pods * Updated properties * Simplified App Backgrounded call * Fixed test since we dropped the param. * Reverted xcode CI version number * LIB-1212: Promoting 3.7.0-beta.4 to release. (segmentio#834) (segmentio#836) * Prepare for release 3.7.0 * Updated cartfile. * Updated version in SEGAnalytics.m * Updated version in readme instructions. * Preparing 3.8.0-beta.0 release. (segmentio#837) (segmentio#838) * Preparing 3.8.0-beta.0 release. * `CoreTelephony` library is now only included on iOS targets. This was done so that tvOS targets could build without linker errors. (segmentio#842) * Add support for SSL Pinning (segmentio#839) * Support SSL pinning Client integrations can optionally pass in a NSURLSessionDelegate in the SEGAnalyticsConfiguration object. If set, NSURLSessionDelegate callbacks are forwarded to the client code where SSL pinning checks can be implemented * test httpSessionDelegate configuration * Fix for LIB-1416 & Github segmentio#846 (segmentio#853) * Fix for LIB-1416 & Github segmentio#846 - Stops blindly passing dictionaries. - Property dictionaries are checked for NSCoding conformance to ensure they can be serialized. - Property dictionaries are deep copied so contents can’t change while the pipeline is in progress. - Puts a try/catch arrangement as a temporary guard against crashes for serialization failures until the storage format can be changed. * Fixed missing ; * Added test for deepCopy/conformance additions. * Swapped JSON in for the storage format instead of plists. (segmentio#854) * Converted file storage to JSON from plist. * Updated string storage to account for JSON vs plist differences. * update podfile lock. * Remove some NSNull hacks. * Updated tests to validate null values. * Fixed LIB-1462 (segmentio#855) * Reload static context data when the app returns from background. (segmentio#856) * Respond to changes regarding advertising ID. * Removed unnecessary context. * Remove extraneous NSNull handling causing tests to fail. * Added weakify/strongify macros. * Removed extraneous NSNull checking. * Put locking around static context access. * Prepare for release 3.8.0-beta.1 * Fix changelog for 3.8.0-beta.1 * Updated carthage versions. * Update config.yml * [tvOS] Move SEGQueue from UserDefaults to caches directory (segmentio#861) * Stops using UserDefaults for queue on tvOS and uses NSCachesDirectory Changes storage to fileStorage and userDefaultsStorage. Utilizes userDefaults on tvOS for information such as anonymousID and configuration, but moves tvOS's queue into the NSCachesDirectory. The reasoning is that tvOS has a 1mb limit for UserDefaults and the queue can grow rapidly in size, leading to app crashes when saving more than 1mb of data to UserDefaults. * Adds a constant for key. Seperate cache dir and appSupport dir functions. Removes unused init. * Adds functionality to remove old UserDefaults queue on tvOS. Updates migrated removal block to account for tvOS now that the queue is no longer in UserDefaults. Adds back in a #else and #endif that was accidently removed. * Adds tvOS unit test target * Adds new AnalyticsTestsTVOS scheme * Updates pods to include all test pods for AnalyticsTestsTVOS * Fixes unit test import for QuickTVOS * Add tvOS options for make file * Enabled code coverage on tvOS tests * Fix up unit test warning "result of expect is never nil" * Adds test to ensure that UserDefaults SEGQueue is cleared on initialization for tvOS & iOS * Adds test to ensure SEGQueue is empty when missing form file storage * Reverts unnecessary import for QuickTVOS * Adds test for FileStorage caches directory helper * Fix up: Adds SwiftTryCatch pod to tvOS test target * Fix up makefile to have correct build target for build-ios & build-tvos * Fix up: updates xcodebuild destination to match devices found on circleci * Break up ios and tvos build/test steps * Circleci: Cache pods * Fix up: tvOS test build * Fix up spacing * Fix up flaky unit test Co-authored-by: Connor Ricks <connor.ricks@gmail.com> * Fix issues around plist->json conversion & nil values (segmentio#862) * Fixing a crash from plist->json conversion where result is not actually a dictionary. * Made code flow the same as non-conversion. * Set compatibility to 10.0. * Fixed issues around setting nil values even though they are expected. * Address Issue segmentio#851; Expect dictionary as well for for integration enablement (segmentio#863) * Address Issue segmentio#851; Expect dictionary as well for for integration enablement. * Fixed broken test. * Differences observed in how iOS/android pass userId/anonId; Corrected. (segmentio#864) * Disabled tvOS tests temporarily. * Updated podfile lock. * Fixed LIB-1698; Differences observed in how ios/android pass userId/anonId in traits. * Another podfile lock update. * Fixed test. * Set swift version for tests. * Reverted podfile lock changes due to incompatibilities. * Look at previously cached settings before blowing them away. (segmentio#866) * Bsneed/timestamps (segmentio#876) * LIB-1656: Added nanosecond timestamps * Actually use the timestamp we’re carrying around. * In case the context is modified, preserve the timestamp. * Bump timestamp nanosecond precision to 9. * Only carry over the timestamp during a modify if there was one to begin with. * Added experimental options to configuration. * Added a second version of 8601 date creation. * Respect experimental value now present in config. * Added nanosecond time test. Co-authored-by: Brandon Sneed <brandon.sneed@segment.com> * Prepare for release 3.8.0-beta.2. * Fixed warning. * Updated carthage files. * Implement maximum batch request size (segmentio#874) * Implement maximum request size * Add test when batch exceeds the size * Execute check before gzip * Remove stub request * Prepare for release 3.8.0. * Updated carthage files. * Misc Fixes (segmentio#884) * Add name and properties to auto screen reporting * Make seg_topViewController handle tab and custom container VCs * Simplify SEGScreenReporting protocol Inspired by comments from @f2prateek, simplify the the `SEGScreenReporting` protocol to replace the name and properties fields with a single method (`seg_trackScreen`) that can be implemented when screen tracking for a specific view controller that needs a custom name, properties, or options. * Update Nimble to build with Xcode 10.2 * Add tests for seg_topViewController * fixed a crash in file storage when trying to get a string stored using old SDK version (segmentio#880) * Fixed issue where build/version were removed from Application Opened events from background state. * Publish filenames used for data storage (segmentio#865) * Remove tvos test from scheme setup. * Fixed selector reference. * Removed unused code. Co-authored-by: David Whetstone <david@humblehacker.com> Co-authored-by: Sergei Guselnikov <arietis@users.noreply.github.com> Co-authored-by: Brandon Sneed <brandon.sneed@segment.com> Co-authored-by: Błażej Biesiada <bejo@users.noreply.github.com> * Add previouslyCachedSettings count (segmentio#889) * Prepare for release 3.8.1 * Updated carthage files to 3.8.1 * Prepare for release 3.8.2. * Updated carthage files for 3.8.2 * Add ability to set default settings is segment.com can't be reached. Backported from segmentio#888 (segmentio#897) Co-authored-by: Brandon Sneed <brandon.sneed@segment.com> * change logic for naming conventions (segmentio#885) * Prepare for release 3.9.0 * Updated carthage files for 3.9.0 Co-authored-by: Daniel Jackins <danieljackins@gmail.com> Co-authored-by: dsjackins <daniel.jackins@segment.com> Co-authored-by: Fathy Boundjadj <fathy.boundjadj@segment.com> Co-authored-by: Carlos Kelly <me@carlos.dev> Co-authored-by: Brandon Sneed <brandon@redf.net> Co-authored-by: Dan Morrow <skydivedan@users.noreply.github.com> Co-authored-by: Ujjawal Garg <47793370+ujjawalgarg@users.noreply.github.com> Co-authored-by: Brandon Sneed <brandon.sneed@segment.com> Co-authored-by: Ben Humphries <iMacHumphries@me.com> Co-authored-by: Connor Ricks <connor.ricks@gmail.com> Co-authored-by: Cristian Lupu <cristian.lupu@ellation.com> Co-authored-by: David Whetstone <david@humblehacker.com> Co-authored-by: Sergei Guselnikov <arietis@users.noreply.github.com> Co-authored-by: Błażej Biesiada <bejo@users.noreply.github.com> Co-authored-by: alanjcharles <50601149+alanjcharles@users.noreply.github.com> Co-authored-by: Ko <kowongh@gmail.com>
kevinfarst-earnin
added a commit
to activehours/analytics-ios
that referenced
this pull request
Sep 25, 2020
* Update Nimble to build with Xcode 10.2 * Add name and properties to auto screen reporting * Make seg_topViewController handle tab and custom container VCs * Simplify SEGScreenReporting protocol Inspired by comments from @f2prateek, simplify the the `SEGScreenReporting` protocol to replace the name and properties fields with a single method (`seg_trackScreen`) that can be implemented when screen tracking for a specific view controller that needs a custom name, properties, or options. * Add tests for seg_topViewController * adding “name” field to payload;updated nimble to version 7.3.4 * Fix GCD mutual dependency (segmentio#785) * Add iOS Backgrounded Event. (segmentio#831) * Add iOS Backgrounded Event. * Bump Xcode CI version * Bump pods * Updated properties * Simplified App Backgrounded call * Fixed test since we dropped the param. * Reverted xcode CI version number * LIB-1212: Promoting 3.7.0-beta.4 to release. (segmentio#834) (segmentio#836) * Prepare for release 3.7.0 * Updated cartfile. * Updated version in SEGAnalytics.m * Updated version in readme instructions. * Preparing 3.8.0-beta.0 release. (segmentio#837) (segmentio#838) * Preparing 3.8.0-beta.0 release. * `CoreTelephony` library is now only included on iOS targets. This was done so that tvOS targets could build without linker errors. (segmentio#842) * Add support for SSL Pinning (segmentio#839) * Support SSL pinning Client integrations can optionally pass in a NSURLSessionDelegate in the SEGAnalyticsConfiguration object. If set, NSURLSessionDelegate callbacks are forwarded to the client code where SSL pinning checks can be implemented * test httpSessionDelegate configuration * Fix for LIB-1416 & Github segmentio#846 (segmentio#853) * Fix for LIB-1416 & Github segmentio#846 - Stops blindly passing dictionaries. - Property dictionaries are checked for NSCoding conformance to ensure they can be serialized. - Property dictionaries are deep copied so contents can’t change while the pipeline is in progress. - Puts a try/catch arrangement as a temporary guard against crashes for serialization failures until the storage format can be changed. * Fixed missing ; * Added test for deepCopy/conformance additions. * Swapped JSON in for the storage format instead of plists. (segmentio#854) * Converted file storage to JSON from plist. * Updated string storage to account for JSON vs plist differences. * update podfile lock. * Remove some NSNull hacks. * Updated tests to validate null values. * Fixed LIB-1462 (segmentio#855) * Reload static context data when the app returns from background. (segmentio#856) * Respond to changes regarding advertising ID. * Removed unnecessary context. * Remove extraneous NSNull handling causing tests to fail. * Added weakify/strongify macros. * Removed extraneous NSNull checking. * Put locking around static context access. * Prepare for release 3.8.0-beta.1 * Fix changelog for 3.8.0-beta.1 * Updated carthage versions. * Update config.yml * [tvOS] Move SEGQueue from UserDefaults to caches directory (segmentio#861) * Stops using UserDefaults for queue on tvOS and uses NSCachesDirectory Changes storage to fileStorage and userDefaultsStorage. Utilizes userDefaults on tvOS for information such as anonymousID and configuration, but moves tvOS's queue into the NSCachesDirectory. The reasoning is that tvOS has a 1mb limit for UserDefaults and the queue can grow rapidly in size, leading to app crashes when saving more than 1mb of data to UserDefaults. * Adds a constant for key. Seperate cache dir and appSupport dir functions. Removes unused init. * Adds functionality to remove old UserDefaults queue on tvOS. Updates migrated removal block to account for tvOS now that the queue is no longer in UserDefaults. Adds back in a #else and #endif that was accidently removed. * Adds tvOS unit test target * Adds new AnalyticsTestsTVOS scheme * Updates pods to include all test pods for AnalyticsTestsTVOS * Fixes unit test import for QuickTVOS * Add tvOS options for make file * Enabled code coverage on tvOS tests * Fix up unit test warning "result of expect is never nil" * Adds test to ensure that UserDefaults SEGQueue is cleared on initialization for tvOS & iOS * Adds test to ensure SEGQueue is empty when missing form file storage * Reverts unnecessary import for QuickTVOS * Adds test for FileStorage caches directory helper * Fix up: Adds SwiftTryCatch pod to tvOS test target * Fix up makefile to have correct build target for build-ios & build-tvos * Fix up: updates xcodebuild destination to match devices found on circleci * Break up ios and tvos build/test steps * Circleci: Cache pods * Fix up: tvOS test build * Fix up spacing * Fix up flaky unit test Co-authored-by: Connor Ricks <connor.ricks@gmail.com> * Fix issues around plist->json conversion & nil values (segmentio#862) * Fixing a crash from plist->json conversion where result is not actually a dictionary. * Made code flow the same as non-conversion. * Set compatibility to 10.0. * Fixed issues around setting nil values even though they are expected. * Address Issue segmentio#851; Expect dictionary as well for for integration enablement (segmentio#863) * Address Issue segmentio#851; Expect dictionary as well for for integration enablement. * Fixed broken test. * Differences observed in how iOS/android pass userId/anonId; Corrected. (segmentio#864) * Disabled tvOS tests temporarily. * Updated podfile lock. * Fixed LIB-1698; Differences observed in how ios/android pass userId/anonId in traits. * Another podfile lock update. * Fixed test. * Set swift version for tests. * Reverted podfile lock changes due to incompatibilities. * Look at previously cached settings before blowing them away. (segmentio#866) * Bsneed/timestamps (segmentio#876) * LIB-1656: Added nanosecond timestamps * Actually use the timestamp we’re carrying around. * In case the context is modified, preserve the timestamp. * Bump timestamp nanosecond precision to 9. * Only carry over the timestamp during a modify if there was one to begin with. * Added experimental options to configuration. * Added a second version of 8601 date creation. * Respect experimental value now present in config. * Added nanosecond time test. Co-authored-by: Brandon Sneed <brandon.sneed@segment.com> * Prepare for release 3.8.0-beta.2. * Fixed warning. * Updated carthage files. * Implement maximum batch request size (segmentio#874) * Implement maximum request size * Add test when batch exceeds the size * Execute check before gzip * Remove stub request * Added Integration Middleware capabilities (segmentio#879) * Added integration middleware support. * Fixed warnings; Updated project to recommended settings. * only signal the runner if there’s actually middleware to be processed. * Added & Updated tests. * Added experimental raw filter block. * Removed unnecessary logs. * Added logic to allow tests to function. Co-authored-by: Brandon Sneed <brandon.sneed@segment.com> * Prepare for release 3.8.0. * Updated carthage files. * Prepare for release 4.0.0-beta.0. * Updated carthage files. * fixed a crash in file storage when trying to get a string stored using old SDK version (segmentio#880) * fixed a crash in file storage when trying to get a string stored using old SDK version (segmentio#880) * Fixed issue where build/version were removed from Application Opened events from background state. * Publish filenames used for data storage (segmentio#865) * Publish filenames used for data storage (segmentio#865) * Remove tvos test from scheme setup. * Fixed selector reference. * Removed unused code. * Misc Fixes (segmentio#884) * Add name and properties to auto screen reporting * Make seg_topViewController handle tab and custom container VCs * Simplify SEGScreenReporting protocol Inspired by comments from @f2prateek, simplify the the `SEGScreenReporting` protocol to replace the name and properties fields with a single method (`seg_trackScreen`) that can be implemented when screen tracking for a specific view controller that needs a custom name, properties, or options. * Update Nimble to build with Xcode 10.2 * Add tests for seg_topViewController * fixed a crash in file storage when trying to get a string stored using old SDK version (segmentio#880) * Fixed issue where build/version were removed from Application Opened events from background state. * Publish filenames used for data storage (segmentio#865) * Remove tvos test from scheme setup. * Fixed selector reference. * Removed unused code. Co-authored-by: David Whetstone <david@humblehacker.com> Co-authored-by: Sergei Guselnikov <arietis@users.noreply.github.com> Co-authored-by: Brandon Sneed <brandon.sneed@segment.com> Co-authored-by: Błażej Biesiada <bejo@users.noreply.github.com> * Update CHANGELOG.md * Add ability to set default settings is segment.com can't be reached. (segmentio#888) * Added integration middleware support. * Fixed warnings; Updated project to recommended settings. * only signal the runner if there’s actually middleware to be processed. * Added & Updated tests. * Added experimental raw filter block. * Removed unnecessary logs. * Added logic to allow tests to function. * Allow for user-supplied settings. * Make sure segment.io is still present in the integrations list. * Added ability to set default settings if segment.com can’t be reached. * Removed test code. Co-authored-by: Brandon Sneed <brandon.sneed@segment.com> * Fixed defaultSettings documentation. * Add previouslyCachedSettings count (segmentio#889) * Add previouslyCachedSettings count (segmentio#889) * Prepare for release 3.8.1 * Updated carthage files to 3.8.1 * Prepare for release 3.8.2. * Update CHANGELOG.md * Updated carthage files for 3.8.2 * Allow customers to set default settings values if segment.com unreachable. (segmentio#891) * Added integration middleware support. * Fixed warnings; Updated project to recommended settings. * only signal the runner if there’s actually middleware to be processed. * Added & Updated tests. * Added experimental raw filter block. * Removed unnecessary logs. * Added logic to allow tests to function. * Allow for user-supplied settings. * Make sure segment.io is still present in the integrations list. * Added ability to set default settings if segment.com can’t be reached. * Removed test code. Co-authored-by: Brandon Sneed <brandon.sneed@segment.com> * Makes IDFA support externally/customer driven. (segmentio#892) * Remove IDFA related bits and push to customers. * Check if ad block is nil before executing * Fixed header reference. * Adjusted IDFA test. Co-authored-by: Brandon Sneed <brandon.sneed@segment.com> * Prepare for release 4.0.0-beta.1 * Updated tests to remove Alamofire (segmentio#895) Co-authored-by: Cody Garvin <cody.garvin@segment.com> * Renamed middleware methods to match a.js naming. (segmentio#896) * Renamed middleware methods to match a.js naming. * Updated a comment re integration/destination. Co-authored-by: Brandon Sneed <brandon.sneed@segment.com> * Add ability to set default settings is segment.com can't be reached. Backported from segmentio#888 (segmentio#897) Co-authored-by: Brandon Sneed <brandon.sneed@segment.com> * change logic for naming conventions (segmentio#885) * Prepare for release 3.9.0 * Updated carthage files for 3.9.0 * Merged 3.9 changelog; Bumped CI xcode version. * change logic for naming conventions (segmentio#885) * LIB-83: Fixed crash on UISceneDelegate applications (segmentio#899) Co-authored-by: Cody Garvin <cody.garvin@segment.com> * Added application object back to notifications (segmentio#900) Co-authored-by: Cody Garvin <cody.garvin@segment.com> * LIB-35: Updated class names for Swift (segmentio#902) Co-authored-by: Cody Garvin <cody.garvin@segment.com> * Added Swift Package Manager support (segmentio#904) * Add global state management (segmentio#905) * First pass at basic state management * First bit of state being shared. * Wrapped up state management. * Commented out old iAd references. * Filled in missing fields and adding messageId * Removed comments * Removed unused code. * Adjustments to nullability Co-authored-by: Brandon Sneed <brandon.sneed@segment.com> * Prepare for release 4.0.1. * Update cartfile.resolved. * LIBMOBILE-77: Removed Quick and Nimble, updated unit tests (segmentio#909) * Spm update (segmentio#911) * LIBMOBILE-77: Removed Quick and Nimble, updated unit tests * Issue 906: Updated package to supports all types of libraries * Payload Info & Traits Fixes (segmentio#912) * Moved some fields from SEGContext to more appropriate SEGPayload. * Fix trait storage/init issue. * Fixed traits usage w/ tests. Co-authored-by: Brandon Sneed <brandon.sneed@segment.com> * Separate public utils from private utils appropriately (segmentio#913) * Separated public utils from private utils * Made SEGAnalyticsUtils public. * Fixed header includes. Co-authored-by: Brandon Sneed <brandon.sneed@segment.com> * Prepare for release 4.0.2 * Fix SwiftUI previews in macOS Catalyst builds (segmentio#914) * Fix Swift Package Manager macOS Catalyst builds Link CoreTelephony to address a link error on macOS Catalyst. * Add macOS to the conditionals for linking CoreTelephony. * Full example (segmentio#915) * Added initial full example app * Added full example app with Swift Package Manager Co-authored-by: Cody Garvin <cody.garvin@segment.com> * LIBMOBILE-109: Updated an issue with new traits not overriding old traits (segmentio#917) * Prepare for release 4.0.3 * Miscellaneous Fixes (segmentio#920) * Fixed issue with userId not being cleared properly in a reset. * Removed SwiftTryCatch dependency * Removed unnecessary bridging header item in tests. * Updated to swift 5 syntax. * Workaround for issue where UIBackgroundTaskIdentifier is diff types between Objc / Swift * Removed unused code. * Fixed issue w/ deadlock setting device token * Fixed tests. Co-authored-by: Brandon Sneed <brandon.sneed@segment.com> * Fixed SEGLog permissions (segmentio#921) * Migs647/macconversion (segmentio#918) * Added Catalyst compatibility * Added MacOS support * Updated example apps to use SPM * Repaired example SPM dependencies * Fixed makefile for carthage to handle iOS only * Prepare for release 4.0.4 * Added Carthage and SwiftPM badge * Disregard payloads that fail conversion from plist to json backing (segmentio#925) * Deprecated configuration access and updated associated tests * [LIBMOBILE-149] Fixed double device payload * Added stubs for edge functions. (segmentio#932) Co-authored-by: Brandon Sneed <brandon.sneed@segment.com> * Fixed property access * Fixed issue where non-serializable types would get into payload (segmentio#937) Co-authored-by: Brandon Sneed <brandon.sneed@segment.com> * Prepare for release 4.0.5 * Rename Reachability to SEGReachability Co-authored-by: David Whetstone <david@humblehacker.com> Co-authored-by: Daniel Jackins <danieljackins@gmail.com> Co-authored-by: dsjackins <daniel.jackins@segment.com> Co-authored-by: Fathy Boundjadj <fathy.boundjadj@segment.com> Co-authored-by: Carlos Kelly <me@carlos.dev> Co-authored-by: Brandon Sneed <brandon@redf.net> Co-authored-by: Dan Morrow <skydivedan@users.noreply.github.com> Co-authored-by: Ujjawal Garg <47793370+ujjawalgarg@users.noreply.github.com> Co-authored-by: Brandon Sneed <brandon.sneed@segment.com> Co-authored-by: Ben Humphries <iMacHumphries@me.com> Co-authored-by: Connor Ricks <connor.ricks@gmail.com> Co-authored-by: Cristian Lupu <cristian.lupu@ellation.com> Co-authored-by: Sergei Guselnikov <arietis@users.noreply.github.com> Co-authored-by: Błażej Biesiada <bejo@users.noreply.github.com> Co-authored-by: alanjcharles <50601149+alanjcharles@users.noreply.github.com> Co-authored-by: Cody Garvin <emig647@gmail.com> Co-authored-by: Cody Garvin <cody.garvin@segment.com> Co-authored-by: Ko <kowongh@gmail.com> Co-authored-by: Matt Gallagher <mattgallagher@users.noreply.github.com> Co-authored-by: Mike Ciesielka <maciesielka@comcast.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixed a crash in the file storage when trying to get a string stored using old SDK version.
Where should the reviewer start?
SEGFileStorage.mHow should this be manually tested?
You need a version of SDK where the string is converted to Data directly without encapsulating it into the Dictionary object. After that upgrade to the version from the PR and it shouldn't crash.
Any background context you want to provide?
To avoid such crashes in the future some migration logic would be helpful.
What are the relevant tickets?
No tickets I know about.
Screenshots or screencasts (if UI/UX change)
No UI/UX changes.
Questions:
Does the docs need an update?
No.
Are there any security concerns?
No.
Do we need to update engineering / success?
No.