Remove the ability to natively report attribution information via Segment integrations #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith mobile-service
prayansh
requested review from
bsneed and
migs647
and removed request for
bsneed
bsneed
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the
trackAttributionDataconfig option and any codepaths that use it. Removes all references tomobile-serviceWhere should the reviewer start?
SEGAnalytics.h -> SEGSegmentIntegration.m -> SEGHTTPClient.m
How should this be manually tested?Any background context you want to provide?
Task is to remove any reference to Mobile Service
What are the relevant tickets?
https://segment.atlassian.net/browse/LIBMOBILE-181