Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing import in Segment.h #994

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Add missing import in Segment.h #994

merged 1 commit into from
Apr 27, 2021

Conversation

JagCesar
Copy link
Contributor

What does this PR do?
Fixes #988 by adding missing import

Where should the reviewer start?
Check that I've imported the correct file

How should this be manually tested?
Try to add Segment to a project and compile using Xcode 12.5. It won't compile and will tell you that an import is missing.

Any background context you want to provide?
Nope

What are the relevant tickets?
#988

Screenshots or screencasts (if UI/UX change)
None

Questions:

  • Does the docs need an update?
    No

  • Are there any security concerns?
    Not afaik

  • Do we need to update engineering / success?
    No idea what this is 😅

@bsneed bsneed merged commit ad3c2a5 into segmentio:master Apr 27, 2021
@bsneed
Copy link
Contributor

bsneed commented Apr 27, 2021

Thanks @JagCesar !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xcode 12.5 Beta 3: Umbrella header for module 'Segment' does not include header 'SEGReachability.h'
2 participants