This repository was archived by the owner on Feb 13, 2024. It is now read-only.
Update loosely-validate-event to 2.0.0 #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #152 |
This version has a breaking change - it'll throw an error for messages > 32kb (as it should, these messages are rejected by the API). Instead of making a breaking change to analytics-node immediately, we'll have a deprecation period for the old behaviour. During this period, we'll catch this error and log it instead. This will give clients time to update their code as needed. We may still opt to make a breaking change for analytics-node after this deprecation period, we'll decide this later.
f2prateek
force-pushed
the
update-loosely-validate-event-2.0.0
branch
from
45b640b to
fd20327
Compare
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
===========================================
- Coverage 100% 46.29% -53.71%
===========================================
Files 1 1
Lines 102 108 +6
===========================================
- Hits 102 50 -52
- Misses 0 58 +58
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version has a breaking change - it'll throw an error for messages > 32kb (as it should, these messages are rejected by the API).
Instead of making a breaking change to analytics-node immediately, we'll have a deprecation period for the old behaviour. During this period, we'll catch this error and log it instead. This will give clients time to update their code as needed.
We may still opt to make a breaking change for analytics-node after this deprecation period, we'll decide this later.