Skip to content

fix: add override fix to ios modules #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2022
Merged

fix: add override fix to ios modules #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/core/ios/AnalyticsReactNative.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ enum ConnectionType: String {

@objc(AnalyticsReactNative)
class AnalyticsReactNative: NSObject {

@objc
static func requiresMainQueueSetup() -> Bool {
return true
}

func getAppName() -> String {
guard let displayName = Bundle.main.infoDictionary!["CFBundleDisplayName"] else {
Expand Down
6 changes: 6 additions & 0 deletions packages/plugins/plugin-idfa/ios/AnalyticsReactNativePluginIdfa.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,13 @@ import AppTrackingTransparency
@objc(AnalyticsReactNativePluginIdfa)
class AnalyticsReactNativePluginIdfa: RCTEventEmitter {

@objc
override static func requiresMainQueueSetup() -> Bool {
return true
}

@available(iOS 14, *)

@objc
func getTrackingAuthorizationStatus(
_ resolve: RCTPromiseResolveBlock,
Expand Down