fix: revert traits behavior #588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reverted the traits behavior to not persist after an `identify` event - Added example plugin `InjectTraits` and documentation for how to preserve this behavior - Added migration guide for Plugins from V1 to V2
alanjcharles
suggested changes
Jun 28, 2022
MIGRATION_GUIDE.md
Outdated
| ### Context Traits | ||
| Previous versions of this library used to persist `traits` accross events after an `identify` was sent inside `context.traits` we're not supporting this out of the box in V2 and the rest of our mobile libraries due concerns of data privacy for some device destinations. Some device mode destinations might not accept events if they contain identifiable data. |
There was a problem hiding this comment.
Previous versions of this library used to persist traits in context.traits across all event types after an identify event was sent. We no longer not support this out of the box in V2 as well as the rest of our mobile libraries due to concerns of data privacy for some device mode destinations. Some device mode destinations might not accept events if they contain identifiable data as it is against their Terms of Service.
MIGRATION_GUIDE.md
Outdated
| segmentClient.add({ plugin: new InjectTraits() }); | ||
| ``` | ||
| Please note that as this is an example we don't offer full support for it nor release it as an npm package. |
There was a problem hiding this comment.
Please note that as this is an example we don't offer full support for it and will not release it as an NPM package.
alanjcharles
approved these changes
Jun 30, 2022
oscb
pushed a commit
that referenced
this pull request
Jun 30, 2022
## [@segment/analytics-react-native-v2.3.2](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-v2.3.1...@segment/analytics-react-native-v2.3.2) (2022-06-30) ### Features * Add AdvertisingId Plugin ([#574](#574)) ([9f47e67](9f47e67)) ### Bug Fixes * revert traits behavior ([#588](#588)) ([516aacd](516aacd))
|
🎉 This PR is included in version @segment/analytics-react-native-v2.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
identifyeventInjectTraitsand documentation for how to preserve this behavior