on macOS, like on tvOS use the caches folder #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on macOS, if the app is not sandboxed, the folder for events storage ends up in the user's `~/Documents/` directory, which potentially gets synced via iCloud Documents. Let's also use the caches directory on macOS.
bsneed
approved these changes
Jan 19, 2022
|
Great catch @diederich ! Thanks so much! Will go out with the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS, if the app is not sandboxed, the folder for events storage ends up in the user's
~/Documents/directory, which potentially gets synced via iCloud Documents.Let's also use the caches directory (
~/Library/Caches/) on macOS, same as tvOS.(I had a previous patch which moved all platforms to caches directory, given the documents folder on iOS might also be synced across devices. WDYT?)