Skip to content

Revert App Opened change from #101 #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2022
Merged

Revert App Opened change from #101 #130

merged 1 commit into from
Mar 28, 2022

Conversation

bsneed
Copy link
Contributor

@bsneed bsneed commented Mar 28, 2022

No description provided.

migs647
migs647 approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@migs647 migs647 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- did just realize we don't have tests in analytics-swift for foregrounding.

@bsneed bsneed merged commit c832f08 into main Mar 28, 2022
@bsneed bsneed deleted the bsneed/app_opened_revert branch March 28, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@migs647 migs647 migs647 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsneed @migs647