Correct time calculations #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfed
commented
Sep 19, 2025
| extension TimeInterval { | ||
| static func milliseconds(_ value: Int) -> TimeInterval { | ||
| return TimeInterval(value / 1000) | ||
| return TimeInterval(value) / 1000 |
Contributor
Author
There was a problem hiding this comment.
This calculation had an integer-division problem. My change makes it so that we're dividing Double types rather than Int types, and therefore are no longer truncating.
dfed
commented
Sep 19, 2025
|
|
||
| static func hours(_ value: Int) -> TimeInterval { | ||
| return TimeInterval(60 * value) | ||
| return TimeInterval(60 * 60 * value) |
Contributor
Author
There was a problem hiding this comment.
a TimeInterval represents a second. There are 60 seconds in a minute, and 60 seconds in an hour.
dfed
commented
Sep 19, 2025
|
|
||
| static func days(_ value: Int) -> TimeInterval { | ||
| return TimeInterval((60 * value) * 24) | ||
| return TimeInterval((60 * 60 * value) * 24) |
bsneed
approved these changes
Oct 13, 2025
Contributor
bsneed
left a comment
bsneed
left a comment
There was a problem hiding this comment.
Oh man, how embarrassing. Thanks for finding it and fixing!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All but one of the extensions on
TimeIntervalinQueueTimer.swiftyielded incorrect values.