This repository was archived by the owner on Sep 3, 2022. It is now read-only.
Replace @ndhoule/defaults with ES6 spread syntax merging #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanmikaelian
changed the title
bryanmikaelian
force-pushed
the
bryan/replace-with-native-functions
branch
2 times, most recently
from
cd461e3 to
aab4d19
Compare
bryanmikaelian
changed the title
bryanmikaelian
force-pushed
the
bryan/replace-with-native-functions
branch
3 times, most recently
from
f679c89 to
c1247d7
Compare
Codecov Report
@@ Coverage Diff @@
## master #185 +/- ##
=========================================
Coverage ? 96.36%
=========================================
Files ? 3
Lines ? 55
Branches ? 0
=========================================
Hits ? 53
Misses ? 2
Partials ? 0
Continue to review full report at Codecov.
|
bryanmikaelian
force-pushed
the
bryan/replace-with-native-functions
branch
from
c1247d7 to
9c0f101
Compare
bryanmikaelian
changed the title
bryanmikaelian
force-pushed
the
bryan/replace-with-native-functions
branch
from
7d8faaf to
de834bf
Compare
added 2 commits
September 17, 2020 08:28
nettofarah
approved these changes
Sep 17, 2020
juliofarah
added a commit
that referenced
this pull request
Mar 19, 2021
This reverts commit 7b59f34.
hbrls
pushed a commit
to nice-fungal/analytics.js-core
that referenced
this pull request
Apr 16, 2021
hbrls
pushed a commit
to nice-fungal/analytics.js-core
that referenced
this pull request
Apr 16, 2021
hbrls
pushed a commit
to nice-fungal/analytics.js-core
that referenced
this pull request
Apr 16, 2021
hbrls
pushed a commit
to nice-fungal/analytics.js-core
that referenced
this pull request
Apr 16, 2021
hbrls
pushed a commit
to nice-fungal/analytics.js-core
that referenced
this pull request
May 31, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR rips out the third party library
@ndhoule/defaultsand replaces it with merges via the ES6's object spread syntax.Test plan
Testing completed successfully using verifying existing unit tests pass and adding additional test coverage. Also verified with e2e tests using the scenarios below:
Each scenario shows me overriding
context.page.searchwithlolproperties merged with
pageDefaultson aTrackcall and supports overridesproperties merged with
pageDefaultson aPagecall and supports overridesNote: There is an existing bug where the
propertiesdoesn't reflect changes tocontext.page. This does not happen in other methodscontext.pagewith defaults exists on aIdentifycall and supports overridescontext.pagewith defaults exists on anAliascall and supports overridescookiedefaults are setstoreenabled by default and values are stored (tested withIdentify)Checklist