Skip to content
This repository was archived by the owner on Sep 3, 2022. It is now read-only.

Remove utils and @ndhoule/keys #194

Merged
merged 7 commits into from
Sep 15, 2020
Merged

Remove utils and @ndhoule/keys #194

merged 7 commits into from
Sep 15, 2020

Conversation

bryanmikaelian
Copy link
Contributor

@bryanmikaelian bryanmikaelian commented Sep 1, 2020 •
edited
Loading

Description

This PR does a few enhancements:

  • Replaces utils/clone with lodash.deepclone
  • Replaces utils/map with Array.prototype.map
  • Replaces utils/each with Array.prototype.each
  • Cleans up some types and usage of var
  • Removes the utils directory and tests
  • Removes @ndhoule/keys
  • Updates the linter to support TypeScript since this PR effectively removes all JS from the codebase.

Test plan

  • Testing completed successfully using unit tests

Checklist

  • Thorough explanation of the issue/solution, and a link to the related issue
  • CI tests are passing
  • Unit tests were written for any new code
  • Code coverage is at least maintained, or increased.

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2020 •
edited
Loading

Codecov Report

Merging #194 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #194   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            3         3           
=========================================
  Hits             3         3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01f29dc...485f10e. Read the comment docs.

@bryanmikaelian bryanmikaelian force-pushed the bryan/replace-with-native-functions-lib-utils branch from 7c91062 to 3b71b10 Compare September 2, 2020 19:58
@bryanmikaelian bryanmikaelian changed the title Replace with utils with Native Functions / lodash functions Remove utils and @ndhoule/keys Sep 2, 2020
@bryanmikaelian bryanmikaelian marked this pull request as ready for review September 2, 2020 20:17
@bryanmikaelian bryanmikaelian requested a review from a team September 2, 2020 20:17
@bryanmikaelian bryanmikaelian force-pushed the bryan/replace-with-native-functions-lib-utils branch from 57a847c to 485f10e Compare September 2, 2020 20:18
nettofarah
nettofarah approved these changes Sep 2, 2020
View reviewed changes
Copy link

@nettofarah nettofarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL trackLink

@bryanmikaelian bryanmikaelian force-pushed the bryan/replace-with-native-functions-lib-utils branch from 485f10e to aa3669a Compare September 14, 2020 13:23
@bryanmikaelian
Copy link
Contributor Author

bryanmikaelian commented Sep 15, 2020 •
edited
Loading

Verified with E2E testing
https://app.segment.build/vt-staging/sources/bryan/debugger

Screen Shot 2020-09-15 at 12 29 52 PM

@bryanmikaelian bryanmikaelian merged commit b2da6b7 into master Sep 15, 2020
@bryanmikaelian bryanmikaelian deleted the bryan/replace-with-native-functions-lib-utils branch September 15, 2020 16:38
@bryanmikaelian bryanmikaelian mentioned this pull request Sep 15, 2020
Merged
4 tasks
juliofarah added a commit that referenced this pull request Mar 19, 2021
@juliofarah
Revert "Remove utils and @ndhoule/keys (#194)"
589602b 
This reverts commit b2da6b7.
hbrls pushed a commit to nice-fungal/analytics.js-core that referenced this pull request Apr 16, 2021
@bryanmikaelian @hbrls
Remove utils and @ndhoule/keys (segmentio#194)
e114803
hbrls pushed a commit to nice-fungal/analytics.js-core that referenced this pull request Apr 16, 2021
@bryanmikaelian @hbrls
Remove utils and @ndhoule/keys (segmentio#194)
ad00442
hbrls pushed a commit to nice-fungal/analytics.js-core that referenced this pull request Apr 16, 2021
@bryanmikaelian @hbrls
Remove utils and @ndhoule/keys (segmentio#194)
492a84e
hbrls pushed a commit to nice-fungal/analytics.js-core that referenced this pull request May 31, 2021
@bryanmikaelian @hbrls
Remove utils and @ndhoule/keys (segmentio#194)
189b2e0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nettofarah nettofarah nettofarah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bryanmikaelian @codecov-commenter @nettofarah