Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettier #40

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add prettier #40

wants to merge 4 commits into from

Conversation

fathyb
Copy link
Contributor

@fathyb fathyb commented Jun 20, 2018

Rebased on #39, please merge it before this one.
Same as segmentio/analytics.js-core#89


This PR adds prettier-eslint, which is just prettier with its output piped to eslint --fix. js files are formatted using eslint rules, while md and json files only using prettier.

husky is added to setup a Git precommit hook, and lint-staged to only check staged files. This will make sure every commit is properly formatted and passes the lint test. This can be bypassed by using the Git commit --no-verify option.

A format script is added to run prettier on all files.

Demo


https://segment.atlassian.net/browse/LIB-413
cc @f2prateek

@fathyb fathyb force-pushed the chore/add-prettier branch from 4e60f78 to 64c9045 Compare June 20, 2018 14:38
@fathyb fathyb changed the title Chore/add prettier Add prettier Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant