Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AWS SDK to v1.16.26 #181

Merged
merged 2 commits into from
Feb 1, 2019
Merged

Update AWS SDK to v1.16.26 #181

merged 2 commits into from
Feb 1, 2019

Conversation

jradtilbrook
Copy link
Contributor

Update to the newest available AWS SDK which is v1.16.26. The main reason behind it is to add support for the credential_process in AWS SDK configuration.

This is the first time I've worked with go since the introduction of modules, so let me know if there's more to it than just bumping the version in go.mod

This resolves #180.

nickatsegment
nickatsegment approved these changes Jan 31, 2019
View reviewed changes
Copy link
Contributor

@nickatsegment nickatsegment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Though the build process uses go modules, we are still trying to maintain compatibility with the old govendor route. So please update vendor/vendor.json as well. Not huge deal, mergeable as is.

@nickatsegment nickatsegment merged commit 0b80a4a into segmentio:master Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickatsegment nickatsegment nickatsegment approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update AWS SDK to v1.16.0
2 participants
@jradtilbrook @nickatsegment