This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
Upgrading emotion from 9 to 11 #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 73e08f7.
|
It failed only on the build size... I can work on making this smaller I guess. |
|
Actually I think the size is fine given only about 4kbs |
|
@Dezzymei would you mind increasing the size limit in your PR so that the build passes, and then I'll merge this in. |
|
@Dezzymei if you don't mind increasing the yarn size limit, so we will get this merged in. Thanks! |
|
Interestingly running it locally suggests there are no size problems which is strange! I will update it to 55 anyway |
|
Done! |
pooyaj
approved these changes
May 2, 2022
|
@Dezzymei looks like the recent commits removed all the changes. Now it is just the size limit change |
This reverts commit a2a278d.
|
Oops - reverted the revert (don't know why I did that!) |
edsonjab
approved these changes
May 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So as to fix #135 with the warnings.