Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Change enum closeBehavior to type #271

Merged
merged 4 commits into from
Nov 16, 2022

Conversation

edsonjab
Copy link
Contributor

@edsonjab edsonjab commented Sep 21, 2022

Change the enum to type because the enum exports has many troubles on the compilation to use the enum on the project importing the enum from the library.

With the type exist the security to let only the specific values for closeBehavior.

Fix issue #266

@nd4p90x nd4p90x linked an issue Sep 22, 2022 that may be closed by this pull request
@MichaelGHSeg MichaelGHSeg merged commit 1f4dba9 into segmentio:master Nov 16, 2022
@edsonjab edsonjab deleted the change_closeBhavior branch April 1, 2023 01:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

closeBehavior enum not exported properly
3 participants