Skip refresh metadata for errored topic, fix #806 #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip refrash metadata in roundTrip about errored topic, such as write message to a not exist topic, kafka will response error UNKNOWN_TOPIC_OR_PARTITION to the topic, it causes indefinitely metadata refreshing. Fixes segmentio#806
achille-roussel
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip refresh metadata for errored topic, fixed the problem metadata refresh indefinitely,
such as write message to a topic that not exist, but kafka disabled topic auto creation.
Fixes #806
Refer to the implementation of #673